Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devfile sample output in deploying-a-devfile-using-odo.adoc #3162

Closed
johnmcollier opened this issue May 12, 2020 · 1 comment · Fixed by #3163
Closed

Update devfile sample output in deploying-a-devfile-using-odo.adoc #3162

johnmcollier opened this issue May 12, 2020 · 1 comment · Fixed by #3163
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it.

Comments

@johnmcollier
Copy link
Member

/kind documentation
/area devfile

The sample output in deploying-a-devfile-using-odo.adoc is out of date and from pre odo 1.2.0. We should update the samples on that page so that they reflect what's current in odo 1.2.0.

For example, the doc has the following for odo push:

   $ odo push
    •  Push devfile component myspring  ...
    ✓  Waiting for component to start [30s]

   Applying URL changes
    ✓  URL myspring-8080: http://myspring-8080.apps-crc.testing created
    ✓  Checking files for pushing [752719ns]
    ✓  Syncing files to the component [887ms]
    ✓  Executing devbuild command "/artifacts/bin/build-container-full.sh" [23s]
    ✓  Executing devrun command "/artifacts/bin/start-server.sh" [2s]
    ✓  Push devfile component myspring [57s]
    ✓  Changes successfully pushed to component

When it should be:

$ odo push

  Validation
   ✓  Validating the devfile [81808ns]

  Creating Kubernetes resources for component myspring
   ✓  Waiting for component to start [5s]

  Applying URL changes
   ✓  URL myspring-8080: http://myspring-8080.apps-crc.testing created

  Syncing to component myspring
   ✓  Checking files for pushing [2ms]
   ✓  Syncing files to the component [1s]

  Executing devfile commands for component myspring
   ✓  Executing devbuild command "/artifacts/bin/build-container-full.sh" [1m]
   ✓  Executing devrun command "/artifacts/bin/start-server.sh" [2s]

  Pushing devfile component myspring
   ✓  Changes successfully pushed to component

We should also mention the --downloadSource flag that was added in 1.2.0.

@openshift-ci-robot openshift-ci-robot added kind/documentation area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels May 12, 2020
@johnmcollier
Copy link
Member Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants