Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync test script code for KUBECONFIG related operation on prow #3203

Closed
amitkrout opened this issue May 19, 2020 · 2 comments
Closed

Sync test script code for KUBECONFIG related operation on prow #3203

amitkrout opened this issue May 19, 2020 · 2 comments
Assignees
Labels
area/refactoring Issues or PRs related to code refactoring kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation

Comments

@amitkrout
Copy link
Contributor

amitkrout commented May 19, 2020

/kind feature
/kind code-refactoring

Which functionality do you think we should add?

kubectl will prevent multiple concurrent writes to the configuration file: it uses a config.lock file and if the lock exists then changes to the configuration file are prevented which has been fixed in the pr #3041.

Now to make the test code in the same logic need to be implemented for OpenShift cluster, however it does not looks straight forward when running it on prow. I can see different type of failure even after implementing the suggestion given on pr #3041. So i am creating a separate issue make the code in sync for both OpenShift and Kubernetes cluster type.

NOTE: Our existing test code is not broken, actually the --project flag which is saving us from the failure against multiple concurrent writes to the KUBECONFIG configuration file.

Discussion thread - #3041 (comment)

Why is this needed?

Code refactoring and ofcourse syncing of test code for OpenShift and Kubernetes cluster type.

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 19, 2020
@prietyc123
Copy link
Contributor

prietyc123 commented May 19, 2020

I have tried out multiple fixes but It seems something fishy happening on prow. @kadel has also given some suggestions on this in comment but it also leads to failure

Again I can see the KUBECONFIG file exported from /tmp/admin.kubeconfig on prow and I tried hardcoding the path just to check where it is getting stuck. Again unexpected failure

In both the cases I observed KUBECONFIG gets copied and set to the temporary config but I am not sure about the behavior of the test. Though our tests are working as expected on travis CI with both kubernetes and openshift cluster. So, It should not be the test related problem. I suspect this could be infra related issue.

Anyway I am going to do a workaround in separate pr in this sprint.

@amitkrout amitkrout changed the title Sync test script code for KUBECONFIG related operation on both OpenShift and Kubernetes cluster type Sync test script code for KUBECONFIG related operation on prow May 20, 2020
@amitkrout
Copy link
Contributor Author

closing it on behalf of #3221.

@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
@rm3l rm3l added this to odo Project Jun 19, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refactoring Issues or PRs related to code refactoring kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants