Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support application testing defined in the devfile v2 #3284

Closed
2 tasks
elsony opened this issue Jun 2, 2020 · 5 comments · Fixed by #3400
Closed
2 tasks

Support application testing defined in the devfile v2 #3284

elsony opened this issue Jun 2, 2020 · 5 comments · Fixed by #3400
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind

Comments

@elsony
Copy link

elsony commented Jun 2, 2020

/kind user-story

User Story

As a user, I want to test my application using the test defined in a devfile. Devfile 2.0 supports defining commands belongs to the test group (devfile/api#27). The test command will be used for running automated testing on the application.

Acceptance Criteria

  • odo test will run test command (command belongs to the test group) specified in the command that belongs to the group test defined in the devfile
  • odo uses this logic to decide which test command to run on odo test:
    • if only one test command is define, use that command regardless of whether that command with isDefault is set to true or not.
    • if more than one test command, execute the one with isDefault set to true
      -odo test --test-command <command name> will execute the command with the given command name regardless of a default test command is defined or not.
    • if more than one test command but no default is defined, error out if --test-command is not use.

Links

/kind user-story
/area devfile

@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Jun 2, 2020
@girishramnani girishramnani added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jun 4, 2020
@girishramnani girishramnani changed the title Support application testing defined in the devfile Support application testing defined in the devfile v2 Jun 4, 2020
@yangcao77
Copy link
Contributor

blocked by: #3291
requires the code for command group validation to be merged

@cdrage
Copy link
Member

cdrage commented Jul 14, 2020

ping @girishramnani @kadel @dharmit should we discuss this a bit more before we merge the PR?

@kadel
Copy link
Member

kadel commented Jul 15, 2020

ping @girishramnani @kadel @dharmit should we discuss this a bit more before we merge the PR?

@cdrage is there anything specific that you want to discuss?

@cdrage
Copy link
Member

cdrage commented Jul 15, 2020

@kadel Nope, just wanted to make sure that there is a clear consensus on getting this merged in since I didn't see any discussion.

But I think this command is great in order to test the commands

@kadel
Copy link
Member

kadel commented Jul 16, 2020

/remove-triage needs-information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants