Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin down the version of gosec and wwhrd on CI scripts #3359

Closed
girishramnani opened this issue Jun 16, 2020 · 5 comments
Closed

pin down the version of gosec and wwhrd on CI scripts #3359

girishramnani opened this issue Jun 16, 2020 · 5 comments
Assignees
@girishramnani
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation

Comments

@girishramnani
Copy link
Contributor

I want to resolve the underlying problem of this and this is the auto upgrading versions of gosec and wwhrd.
opening an issue to track and resolving that ASAP as well

Originally posted by @girishramnani in #3358 (comment)
@girishramnani girishramnani mentioned this issue Jun 16, 2020
Merged
@girishramnani girishramnani added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 16, 2020
@girishramnani girishramnani self-assigned this Jun 16, 2020
@girishramnani girishramnani mentioned this issue Jun 16, 2020
Closed
@amitkrout
Copy link
Contributor 

$ go get github.com/onsi/ginkgo@1.12.0
go: cannot use path@version syntax in GOPATH mode

It does not work because odo does not use go mod package management.

However the new feature in go version 1.4.* can fetch the specific tag version like go get github.com/onsi/ginkgo@<tag> but our CI environment comprises go version 1.13.*. I have raised a concern via onsi/ginkgo#707 to know how ginkgo binary is built and published.

@prietyc123
Copy link
Contributor

@amitkrout Did you looked into onsi/ginkgo#707 (comment) if it works for us.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 13, 2020
@dharmit dharmit removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 28, 2020
@girishramnani
Copy link
Contributor Author

it seems this was already done when we moved to gomod
https://github.com/openshift/odo/blob/9200a7f99c2627c64d8ea2145aecf3ea2868d244/Makefile#L101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishramnani girishramnani

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dharmit @openshift-bot @girishramnani @amitkrout @openshift-ci-robot @prietyc123