Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preStart lifecycle event support #3565

Closed
upLukeWeston opened this issue Jul 14, 2020 · 3 comments · Fixed by #3742
Closed

preStart lifecycle event support #3565

upLukeWeston opened this issue Jul 14, 2020 · 3 comments · Fixed by #3742
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind

Comments

@upLukeWeston
Copy link
Contributor

User Story

As a stack creator, I want to be able to define commands that will be run before any containers have been initialized during odo push (preStart events), in the form of Init Containers.

Acceptance Criteria

  • It should follow the specification as defined in devfile/kubernetes-api#32 to support execution of the commands based on the events.
  • preStart events should run before any of the other containers are started. Refer to design and discussions here for further details.

Links

/kind user-story
/area devfile

@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Jul 14, 2020
@maysunfaisal
Copy link
Contributor

maysunfaisal commented Jul 16, 2020

will check if we need this issue or it can be covered by parent issue #3569 in a single sprint

@maysunfaisal
Copy link
Contributor

Had discussion about this on Jul 21'st odo contributors meeting https://docs.google.com/document/d/127JAIs5NJze9W5yVOpULgnD-2HXuGZu1x6_LXGd8keY

To summarize,

Q. Acc to odo proposal doc, preStart translates to init containers. But init containers are mutually exclusive to app containers in a pod acc to Kube doc. So is there a point to preStart if the preStart commands won't have a pvc? Do we rely on devfile authors to be aware of this?

A. Start as init containers, check if access to /projects break sync. We could document it as a warning. Most probably this use case will be  for something external

@maysunfaisal
Copy link
Contributor

Ran into a few issues during implementation of preStart. Raised a few points for discussion here devfile/api#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants