Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for composite run commands #5054

Closed
1 task
kadel opened this issue Sep 8, 2021 · 1 comment · Fixed by #5841
Closed
1 task

Add support for composite run commands #5054

kadel opened this issue Sep 8, 2021 · 1 comment · Fixed by #5841
Assignees
@rm3l
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@kadel
Copy link
Member

kadel commented Sep 8, 2021 •
edited
Loading

Odo currently doesn't support run commands that are composite.

  • this needs to support parallel flag as well

simple example with composite run command for testing

schemaVersion: 2.1.0
metadata:
  name: nodejs

components:
  - container:
      endpoints:
        - name: http-3000
          targetPort: 3000
      image: registry.access.redhat.com/ubi8/nodejs-14:latest
    name: runtime

commands:
  - id: install
    exec:
      commandLine: npm install
      component: runtime
      workingDir: /projects
  - id: start
    exec:
      workingDir: /projects
      commandLine: npm start
      component: runtime
  - id: run
    composite:
      commands:
        - install
        - start
      group:
        isDefault: true
        kind: run

/kind feature
/priority high
@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Sep 8, 2021
@dharmit dharmit mentioned this issue Oct 14, 2021
Closed
2 tasks
@kadel kadel changed the title Add support for composite run commands Add support for composite commands Oct 15, 2021
@kadel kadel changed the title Add support for composite commands Add support for composite run commands Oct 15, 2021
@kadel kadel added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Apr 28, 2022
@kadel kadel added this to the v3.0.0-beta2 milestone May 6, 2022
@kadel
Copy link
Member Author

kadel commented Jun 2, 2022

blocked on merging #5648 first

/status blocked

@joshira-rh joshira-rh moved this to In Progress in odo v3-beta1 Jun 14, 2022
@rm3l rm3l mentioned this issue Jun 15, 2022
Closed
2 tasks
@kadel kadel mentioned this issue Jun 16, 2022
Closed
3 tasks
@rm3l rm3l mentioned this issue Jun 20, 2022
Merged
3 tasks
@rm3l rm3l moved this from In Progress to For Review in odo v3-beta1 Jun 21, 2022
@kadel kadel removed this from the v3.0.0-beta2 milestone Jun 22, 2022
Repository owner moved this from For Review to Done in odo v3-beta1 Jun 24, 2022
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rm3l rm3l

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
No open projects
odo v3-beta1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for composite run/debug commands rm3l/odo
4 participants
@kadel @rm3l @dharmit @feloy