Support image component and deploy devfile command / initial odo deploy implementation

[kadel]

/kind user-story

User Story

As a developer I want to be able to use devfile.yaml with outer loop support (using devfile's image component and deploy command)

Acceptance Criteria

• odo should be able to parse Devfile with image components and build+push the image #5145
• odo deploy should trigger a default deploy command (group.kind: deploy.) and execute all the defined steps #5151

Links

• Related Epic (mandatory): Add odo deploy command for initial transition from inner to outer loop #2756

Implementation notes

• odo deploy should use local machine to build the image
• autodetect and use container engine that is available on the local machine (we will start with podman or docker)
• interaction with container engine? Executing cli vs apis (https://docs.podman.io/en/latest/_static/api.html, https://docs.docker.com/engine/api/) Starting with simply executing cli might be easier, as both podman and docker have more or less same interface)
• there is no odo or devfile specific way to handle image registry credentials, it will reduce whatever is configured for local container engine (set by docker login or podman login)

Open questions:

• how to make sure that application deployed using odo push doesn't collide with odo deploy?

/kind user-story

[scottkurz]

Just reacting to:

there is no odo or devfile specific way to handle image registry credentials, it will reduce whatever is configured for local container engine

There is this example in the outer loop proposal.

Maybe that'd be good for a later issue/story.

[kadel]

Just reacting to:

there is no odo or devfile specific way to handle image registry credentials, it will reduce whatever is configured for local container engine

There is this example in the outer loop proposal.

Maybe that'd be good for a later issue/story.

@scottkurz It looks like this did not get into the first draft of the specification.

There is no envFrom property in current Devfile 2.2.0 spec (https://devfile.io/docs/devfile/2.2.0/user-guide/api-reference.html)

And I would say that that is a good thing. We are starting with local build and referencing secrets from cluster would be tricky, and I'm not sure that this is what would users expect.

We can look into this later once we start thinking about remote (in cluster) builds.

[dharmit]

For the first iteration:

• fetching devfile and all the manifest is out of the scope. We better create our own sample and simple manifests.
• add support for "composite" commands which odo doesn't have right now Add support for composite run commands #5054

High level scope for Sprint 209:

• add support for building images using podman and docker in the first iteration (using os.Exec, no APIs)
• add support for composite commands (@kadel to provide an example other than a devfile that has deploy)

[kadel]

• add support for building images using podman and docker in the first iteration (using os.Exec, no APIs)

created #5145 to capture this

• add support for composite commands (@kadel to provide an example other than a devfile that has deploy)

issue already exists #5054
I'll add example to #5054

While looking at #5054 I figured out that odo already supports composite commands (for example as build commands) problem is only with composite commands as run commands, this is due to the fact that odo executes run commands via supervisor, so it is a bit trickier.
But for deploy command we should not have this problem, so the current way of handling composite commands that is alredy there for build should work

[serenamarie125]

@kadel is it fair to say that we will support devfile 2.2 with this?

[kadel]

@kadel is it fair to say that we will support devfile 2.2 with this?

yes, this was only new thing added in 2.2, so after this is implemented we can say that odo supports devfile 2.2

[dharmit]

@kadel can you open an issue for odo undeploy or odo deploy --delete whatever it is that we would want to use to delete the resource deployed by odo deploy?

Also, should we have some command to show the user a list of resources (deployed by odo deploy) along with their state? I'm drawing parallels with odo component list command, which tells the user if the component is pushed. Similarly odo url list, odo service list. How would a user know the state of the resources created by odo deploy?

[kadel]

@kadel can you open an issue for odo undeploy or odo deploy --delete whatever it is that we would want to use to delete the resource deployed by odo deploy?

#5246

Also, should we have some command to show the user a list of resources (deployed by odo deploy) along with their state? I'm drawing parallels with odo component list command, which tells the user if the component is pushed. Similarly odo url list, odo service list. How would a user know the state of the resources created by odo deploy?

@dharmit feel free to create issue for that

[kadel]

implemented in #5228
/close

[openshift-ci]

@kadel: Closing this issue.

In response to this:

implemented in #5228
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.