Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo should be able to parse Devfile with image components and build+push the image #5145

Closed
7 tasks
Tracked by #5109
kadel opened this issue Oct 15, 2021 · 1 comment · Fixed by #5192
Closed
7 tasks
Tracked by #5109

odo should be able to parse Devfile with image components and build+push the image #5145

kadel opened this issue Oct 15, 2021 · 1 comment · Fixed by #5192
Assignees
Labels
estimated-size/XL (40-60) Rough sizing for Epics. About 3 sprints of work for a person kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@kadel
Copy link
Member

kadel commented Oct 15, 2021

This is part of a larger user story #5109.
Because we don't want partial implementation of odo deploy command we will create a new command that will just build and push all image components in devfile without the deploy step.

Acceptance criteria:

  • odo should be able to parse Devfile with image components using devfile/library 1.2.0 and trigger image build and push using docker or podman
  • odo build-images sub-command builds all image components defined in the devfile
  • odo build-images --push builds and push all image components defined in the devfile
  • odo can detect if podman or docker is installed on local machine (if both, it should use podman)
  • the image build and push actions are done via podman/docker using their cli (odo will execute podman/docker commands)
  • Docs for using this new command
  • Tests

Implementation Notes:

  • autodetect and use container engine that is available on the local machine (we will start with podman or docker)
  • there is no odo or devfile specific way to handle image registry credentials, it will reduce whatever is configured for local container engine (set by docker login or podman login)

/priority high
/kind feature

@kadel kadel changed the title odo should be able to parse Devfile with image components using devfile/library 1.2.0 and trigger image build and push using docker or podman odo should be able to parse Devfile with image components and build+push the image Oct 15, 2021
@kadel
Copy link
Member Author

kadel commented Oct 15, 2021

/priority high
/kind feature

@openshift-ci openshift-ci bot added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Oct 15, 2021
@dharmit dharmit added triage/needs-information Indicates an issue needs more information in order to work on it. estimated-size/XL (40-60) Rough sizing for Epics. About 3 sprints of work for a person triage/ready and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 18, 2021
@dharmit dharmit assigned feloy and unassigned valaparthvi Oct 20, 2021
@feloy feloy mentioned this issue Oct 28, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimated-size/XL (40-60) Rough sizing for Epics. About 3 sprints of work for a person kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants