Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo deploy should trigger a default deploy command (group.kind: deploy.) and execute all the defined steps #5151

Closed
2 tasks
Tracked by #5109
kadel opened this issue Oct 18, 2021 · 6 comments · Fixed by #5228
Closed
2 tasks
Tracked by #5109
Assignees
Labels
area/deploy Issues or PRs specific to the `odo deploy` command estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@kadel
Copy link
Member

kadel commented Oct 18, 2021

User story:
As a developer I want to be able to easily deploy my application based on the outerloop definition in devfile, so I can test my application running exactly how it will run in production.

Acceptance criteria:

  • odo deploy should trigger a default deploy command (group.kind: deploy.) and execute it based on how it is defined
  • during push, do not deploy components referenced in a devfile command1

part of the bigger user story #5109

@kadel kadel added the kind/user-story An issue of user-story kind label Oct 18, 2021
@dharmit dharmit added the area/deploy Issues or PRs specific to the `odo deploy` command label Oct 28, 2021
@dharmit
Copy link
Member

dharmit commented Oct 28, 2021

@kadel can you provide an example of the devfile that should be workable with odo as a part of this feature?

@kadel
Copy link
Member Author

kadel commented Nov 2, 2021

@kadel can you provide an example of the devfile that should be workable with odo as a part of this feature?

https://github.com/devfile/api/blob/main/samples/devfiles/outerloop-dockerfile-build-inlined-deploy-devfile.yaml

@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Nov 4, 2021
@valaparthvi valaparthvi added the triage/needs-information Indicates an issue needs more information in order to work on it. label Nov 8, 2021
@valaparthvi
Copy link
Contributor

Look into composite commands.

@feloy
Copy link
Contributor

feloy commented Nov 9, 2021

pkg.devfile.adapters.common provides an object to work with commands, but Apply commands are not supported yet, only Composite and Exec commands. Support for Apply commands should be added

@feloy feloy added triage/ready and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Nov 9, 2021
@dharmit dharmit added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Nov 10, 2021
@feloy feloy mentioned this issue Nov 12, 2021
6 tasks
@feloy
Copy link
Contributor

feloy commented Nov 12, 2021

@kadel Do we need to set owner References in the deployed Kubernetes resources? Which resource should be the owner?

@kadel
Copy link
Member Author

kadel commented Nov 18, 2021

@kadel Do we need to set owner References in the deployed Kubernetes resources? Which resource should be the owner?

I don't think that we need to.
If the devfile is using kubernetes components for deploy definition, odo doesn't have a way to know which resource is the "main" one. So if we would like to set it we wouldn't know to what resource we should point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy Issues or PRs specific to the `odo deploy` command estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants