Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabs for Mac / Windows / Linux environments & warn users on differences. #6085

Closed
2 tasks
Tracked by #6068
cdrage opened this issue Sep 1, 2022 · 0 comments · Fixed by #6115
Closed
2 tasks
Tracked by #6068

Add tabs for Mac / Windows / Linux environments & warn users on differences. #6085

cdrage opened this issue Sep 1, 2022 · 0 comments · Fixed by #6115
Assignees
@cdrage
Milestone
v3.0.0 🚀

Comments

@cdrage
Copy link
Member

cdrage commented Sep 1, 2022

  • if there is a difference between OSes, the OS switcher should be on top of the page as well
  • if there is something that is different only for one OSe (like M1) make it a warning block
@cdrage cdrage mentioned this issue Sep 1, 2022
Closed
8 tasks
cdrage added a commit to cdrage/odo that referenced this issue Sep 1, 2022
@cdrage
Adds tabs for mac / windows / linux environments in docs
7188302 
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind documentation

**What does this PR do / why we need it:**
* Updates the documentation with regards to different operating systems
  when deploying an image

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#6085

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage mentioned this issue Sep 1, 2022
Closed
@rm3l rm3l added this to odo v3.0.0 Sep 2, 2022
@rm3l rm3l moved this to For Review in odo v3.0.0 Sep 7, 2022
@cdrage cdrage mentioned this issue Sep 12, 2022
Merged
cdrage added a commit to cdrage/odo that referenced this issue Sep 12, 2022
@cdrage
Adds tabs for mac / windows / linux environments in docs
23280ce 
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind documentation

**What does this PR do / why we need it:**
* Updates the documentation with regards to different operating systems
  when deploying an image

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#6085
openshift-merge-robot pushed a commit that referenced this issue Sep 13, 2022
@cdrage @rm3l
Adds tabs for podman/docker docs and OS differences (#6115)
8a99a86 
* Adds tabs for mac / windows / linux environments in docs

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind documentation

**What does this PR do / why we need it:**
* Updates the documentation with regards to different operating systems
  when deploying an image

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes #6085

* Update docs/website/docs/user-guides/deploy/_prerequisites.mdx

Co-authored-by: Armel Soro <armel@rm3l.org>

Co-authored-by: Armel Soro <armel@rm3l.org>
Repository owner moved this from For Review to Done in odo v3.0.0 Sep 13, 2022
valaparthvi pushed a commit to valaparthvi/odo that referenced this issue Sep 15, 2022
@cdrage @rm3l @valaparthvi
Adds tabs for podman/docker docs and OS differences (redhat-developer…
ee25841 
…#6115)

* Adds tabs for mac / windows / linux environments in docs

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind documentation

**What does this PR do / why we need it:**
* Updates the documentation with regards to different operating systems
  when deploying an image

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#6085

* Update docs/website/docs/user-guides/deploy/_prerequisites.mdx

Co-authored-by: Armel Soro <armel@rm3l.org>

Co-authored-by: Armel Soro <armel@rm3l.org>
@rm3l rm3l added this to the v3.0.0 🚀 milestone Sep 30, 2022
@rm3l rm3l added this to odo Project Sep 30, 2022
@rm3l rm3l moved this to Done ✅ in odo Project Sep 30, 2022
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
None yet
Projects
odo Project
Archived in project
odo v3.0.0
Status: Done
Milestone
v3.0.0 🚀
2 participants
@rm3l @cdrage