Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate command output in docs #6192

Open
5 of 27 tasks
valaparthvi opened this issue Oct 4, 2022 · 7 comments
Open
5 of 27 tasks

Automate command output in docs #6192

valaparthvi opened this issue Oct 4, 2022 · 7 comments
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.

Comments

@valaparthvi
Copy link
Contributor

valaparthvi commented Oct 4, 2022

/area documentation
/kind epic

What mistake did you find / what is missing in the documentation / what is the relevance of it?

  1. Store the current output for all the commands in separate mdx files.
  2. Write integration/unit tests comparing the real time output of a command with the one stored in the mdx files.
  3. If the test fails, it means that we need to update the output in mdx files.
  4. The tests will be run in the CI for every PR.

For reference - https://www.youtube.com/watch?v=AQDILnknTJ0&list=PLUJzERpatfsWYhMH0NOjSXemQh5Tu9g1W&index=32&t=3s (it is in french)

Acceptance Criteria

Example PR: #6442

@openshift-ci openshift-ci bot added area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/bug Categorizes issue or PR as related to a bug. labels Oct 4, 2022
@rm3l rm3l added this to odo v3.0.0 Oct 4, 2022
@rm3l rm3l removed this from odo v3.0.0 Oct 4, 2022
@rm3l rm3l added this to odo Project Oct 4, 2022
@rm3l
Copy link
Member

rm3l commented Oct 4, 2022

Is this a bug? Or a feature? :-p

@valaparthvi valaparthvi added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 13, 2022
@rm3l rm3l added kind/user-story An issue of user-story kind and removed kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Nov 3, 2022
@valaparthvi
Copy link
Contributor Author

LGTM. I agree there is a lot of repetitive data, but since the Devfiles are quite different, it might be hard to factorize, IMO. Not an expert with MDX / JSX stuff, but there might be some room for reusability. So I am not sure it would be worth spending time right now trying to optimize this.

However, this makes me think of 2 things:

  • Based on a recent discussion, maybe we could use each of those Devfiles as input in E2E tests, and import them as is in these docs. This way, we would be able to test them as well. And for line highlighting in the Docs, I can imagine some generic MDX Component accepting the path to the Devfile along with line numbers as input properties, so as to keep highlighting the relevant lines.

  • These Advanced Guides could be simplified further now that we support parsing multi-document YAML in a single K8s component (Add support for parsing multiple k8s definition in a single Devfile K8s component #6372)

But that's another story that can be handled in separate PRs.

#6388 (review)

@feloy feloy added this to the v3.5.0 🚀 milestone Dec 14, 2022
@valaparthvi valaparthvi moved this to In Progress 🚧 in odo Project Jan 3, 2023
@rm3l rm3l modified the milestones: v3.5.0 🚀, v3.6.0 🚀 Jan 3, 2023
@valaparthvi valaparthvi added kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks and removed kind/user-story An issue of user-story kind labels Jan 5, 2023
@valaparthvi valaparthvi removed their assignment Jan 5, 2023
@feloy feloy mentioned this issue Jan 20, 2023
3 tasks
@rm3l rm3l modified the milestones: v3.6.0 🚀, v3.7.0 🚀 Jan 23, 2023
@rm3l rm3l modified the milestones: v3.7.0 🚀, v3.8.0 🚀 Feb 15, 2023
@kadel kadel added the priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. label Feb 23, 2023
@rm3l rm3l added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person labels Jul 10, 2023
@rm3l rm3l removed the status in odo Project Jul 11, 2023
@rm3l
Copy link
Member

rm3l commented Jul 11, 2023

As discussed, this low-priority item (from the 2023Q1 goals) has been moved back into the backlog. We should break this down into several small issues.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Dec 3, 2023

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 3, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Dec 3, 2023
@rm3l
Copy link
Member

rm3l commented Dec 4, 2023

/reopen
/remove-lifecycle stale
/remove-lifecycle rotten
/lifecycle frozen

@openshift-ci openshift-ci bot reopened this Dec 4, 2023
Copy link

openshift-ci bot commented Dec 4, 2023

@rm3l: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle stale
/remove-lifecycle rotten
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 4, 2023
@github-project-automation github-project-automation bot moved this from Done ✅ to To Do 📝 in odo Project Dec 4, 2023
@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Dec 4, 2023
@rm3l rm3l removed the status in odo Project Dec 4, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Dec 4, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
Status: No status
Development

No branches or pull requests

4 participants