Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass TELEMETRY_CALLER down to devfile registry #6278

Closed
1 task
kadel opened this issue Nov 2, 2022 · 0 comments · Fixed by #6382
Closed
1 task

Pass TELEMETRY_CALLER down to devfile registry #6278

kadel opened this issue Nov 2, 2022 · 0 comments · Fixed by #6382
Assignees
@feloy
Labels
area/telemetry Issues or PRs related to telemetry or metrics collection kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Milestone
v3.4.0 🚀

Comments

@kadel
Copy link
Member

kadel commented Nov 2, 2022

/kind user-story

User Story

As an odo developer, I want to know what Devfile stacks are being downloaded by odo and plugins that are using odo So that I can compare usage between plugins and odo cli and better plan new features.

Acceptance Criteria

  • if TELEMETRY_CALLER (allow passing caller to telemetry #6147) is set, odo should pass caller information to PullStackFromRegistry function. If odo called from cli callers should be odo (as it is now), if TELEMETRY_CALLER is set then the caller passed down to PUllStackFromRegistry should be odo-<TELEMETRY_CALLER>.

/kind user-story
@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Nov 2, 2022
@kadel kadel added priority/Medium Nice to have issue. Getting it done before priority changes would be great. and removed kind/user-story An issue of user-story kind labels Nov 2, 2022
@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Nov 2, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 2, 2022
@rm3l rm3l added this to odo Project Nov 2, 2022
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 21, 2022
@kadel kadel added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). and removed priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Dec 5, 2022
@feloy feloy mentioned this issue Dec 6, 2022
Merged
3 tasks
@rm3l rm3l added this to the v3.4.0 🚀 milestone Dec 6, 2022
@rm3l rm3l added the area/telemetry Issues or PRs related to telemetry or metrics collection label Dec 6, 2022
@feloy feloy moved this to In Review 👀 in odo Project Dec 7, 2022
Repository owner moved this from In Review 👀 to Done ✅ in odo Project Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/telemetry Issues or PRs related to telemetry or metrics collection kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
odo Project
Archived in project
Milestone
v3.4.0 🚀
Development

Successfully merging a pull request may close this issue.

Pass caller to registry telemetry feloy/odo
3 participants
@kadel @rm3l @feloy