Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wins tests fail only if e2e tests fail #6342

Closed
feloy opened this issue Nov 23, 2022 · 1 comment · Fixed by #6345
Closed

Wins tests fail only if e2e tests fail #6342

feloy opened this issue Nov 23, 2022 · 1 comment · Fixed by #6345
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@feloy
Copy link
Contributor

feloy commented Nov 23, 2022

/kind bug

Windosw tests on IBM Cloud fail only if e2e tests fail.

If integration tests fail, the complete test pass.

[...]
Summarizing 1 Failure:
  [FAIL] odo init interactive command tests [It] should print automation command with proper values [nocluster]
  C:/Users/Administrator.ANSIBLE-TEST-VS/2586/tests/integration/interactive_init_test.go:123

Ran 91 of 427 Specs in 18.435 seconds
FAIL! -- 90 Passed | 1 Failed | 0 Pending | 336 Skipped


Ginkgo ran 1 suite in 42.7933764s

Test Suite Failed
exit status 1
make: *** [Makefile:197: test-integration-no-cluster] Error 1
[...]

Ran 326 of 427 Specs in 994.369 seconds
SUCCESS! -- 326 Passed | 0 Failed | 0 Pending | 101 Skipped


Ginkgo ran 1 suite in 16m47.6261506s
Test Suite Passed

[...]

Ran 4 of 4 Specs in 138.250 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 0 Skipped


Ginkgo ran 1 suite in 2m25.1988222s
Test Suite Passed

[...]

Finished: SUCCESS

What versions of software are you using?

Operating System:

Output of odo version:

How did you run odo exactly?

Actual behavior

Expected behavior

Any logs, error output, etc?

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 23, 2022
@rm3l rm3l added this to odo Project Nov 23, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 23, 2022
@anandrkskd
Copy link
Contributor

I think it's due to recent change in powershell script, we should check the exit code for no-cluster test as we do it for e2e or integration-test (cluster)
here is how can we do it.
I will open up a PR with the fix.

@rm3l rm3l added this to the v3.4.0 🚀 milestone Nov 24, 2022
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 24, 2022
@rm3l rm3l moved this to In Review 👀 in odo Project Nov 24, 2022
Repository owner moved this from In Review 👀 to Done ✅ in odo Project Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants