Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parent devfiles into specific directories #6817

Closed
feloy opened this issue May 15, 2023 · 0 comments · Fixed by #6818
Closed

Move parent devfiles into specific directories #6817

feloy opened this issue May 15, 2023 · 0 comments · Fixed by #6818
Assignees
@feloy
Labels
area/refactoring Issues or PRs related to code refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug.
Milestone
v3.11.0 🚀

Comments

@feloy
Copy link
Contributor

feloy commented May 15, 2023

/kind bug

Parent Devfiles are placed in pkg/libdevfile/testdata, but the specification says that all files into the directory of the parent Devfile wil be part of the Devfile stack.

We need to create sub-directories into pkg/libdevfile/testdata, one for each parent devfile.

Related to devfile/api#1118
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 15, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label May 15, 2023
@feloy feloy mentioned this issue May 15, 2023
Merged
3 tasks
@feloy feloy self-assigned this May 15, 2023
@rm3l rm3l added this to the v3.11.0 🚀 milestone May 15, 2023
@rm3l rm3l added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering area/refactoring Issues or PRs related to code refactoring and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels May 15, 2023
@feloy feloy moved this to In Review 👀 in odo Project May 16, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/refactoring Issues or PRs related to code refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug.
Projects
odo Project
Archived in project
Milestone
v3.11.0 🚀
Development

Successfully merging a pull request may close this issue.

Move parent devfiles in specific directories feloy/odo
2 participants
@rm3l @feloy