Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show formatted json for machine readable output #2267

Merged

Conversation

girishramnani
Copy link
Contributor

What is the purpose of this change? What does it change?

Use formatted json output for Machine Readable Output, This aligns us with oc and kubectl and also makes it easy for developers to consume the output.
Used the same spacing and prefix used by oc

Was the change discussed in an issue?

fixes ##2235

How to test changes?

odo list -o json
# or any other json output to confirm that the output is formatted

@cdrage
Copy link
Member

cdrage commented Oct 10, 2019

/retest

Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and code looks great from me.

Tests look like they're failing, but that seems to be a flake (since 4.1 passes fine...)

/approve
/hold

Remove the hold when you're ready for merge!

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Oct 10, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 10, 2019
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 11, 2019
@dharmit
Copy link
Member

dharmit commented Oct 11, 2019

level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"
2019/10/10 15:10:57 Container setup in pod integration failed, exit code 1, reason Error

/test v4.1-integration

@dharmit
Copy link
Member

dharmit commented Oct 11, 2019

level=error msg="Error: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached."

/test v4.2-benchmark

@dharmit
Copy link
Member

dharmit commented Oct 11, 2019

@girishramnani something wrong with the tests?


�[91m�[1mSummarizing 2 Failures:�[0m

�[91m�[1m[Fail] �[0m�[90modo component command tests �[0m�[0mCreating component �[0m�[91m�[1m[It] should list out component in json format along with path flag �[0m
�[37m/go/src/github.com/openshift/odo/tests/integration/component.go:115�[0m

�[91m�[1m[Fail] �[0m�[90modo component command tests �[0m�[0mCreating component �[0m�[91m�[1m[It] should list out pushed components of different projects in json format along with path flag �[0m
�[37m/go/src/github.com/openshift/odo/tests/integration/component.go:146�[0m

@girishramnani
Copy link
Contributor Author

Seems like, I am trying to figure out what. I even flattened the json output

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 11, 2019
@girishramnani
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Oct 11, 2019
@dharmit
Copy link
Member

dharmit commented Oct 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit d1d002d into redhat-developer:master Oct 11, 2019
@girishramnani girishramnani deleted the indented_mro branch October 11, 2019 10:12
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants