-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show formatted json for machine readable output #2267
show formatted json for machine readable output #2267
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation and code looks great from me.
Tests look like they're failing, but that seems to be a flake (since 4.1 passes fine...)
/approve
/hold
Remove the hold when you're ready for merge!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test v4.1-integration |
/test v4.2-benchmark |
@girishramnani something wrong with the tests?
|
Seems like, I am trying to figure out what. I even flattened the json output |
/hold cancel |
/lgtm |
What is the purpose of this change? What does it change?
Use formatted json output for Machine Readable Output, This aligns us with oc and kubectl and also makes it easy for developers to consume the output.
Used the same spacing and prefix used by
oc
Was the change discussed in an issue?
fixes ##2235
How to test changes?