-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Generate codecov reports for PRs #2418
Conversation
/test v4.3-integration-e2e-benchmark |
cf5ee8a
to
fb11983
Compare
/test v4.3-integration-e2e-benchmark |
scripts/generate-coverage.sh
Outdated
@@ -5,7 +5,7 @@ | |||
|
|||
set -e | |||
echo "" > coverage.txt | |||
go test -i -race ./cmd/odo | |||
#go test -i -race ./cmd/odo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please remove this commented code?
.codecov.yml
Outdated
@@ -1,10 +1,35 @@ | |||
codecov: | |||
require_ci_to_pass: no | |||
|
|||
comment: | |||
behavior: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default behavior updates the coverage info but when updating, the creation date of the comment will stay the same. There will be an edited link with a drop-down where you can check the times updated.
there is a new
setting which deletes old and post new one. Would considering that be better @kanchwala-yusuf ?
cc @kadel
@girishramnani, Forgot to add the WIP in the PR title. The changes in the PR are tentative and subject to change. |
This PR requires codecov to be enabled at the openshift org level. @amitkrout is following the due procedure for the same. Once, that is done, this PR can progress ahead. cc: @kadel , @amitkrout |
Created a jira task of priority Urgent in |
@kanchwala-yusuf This is the last update i got on the jira
Seems the access has been granted. Can you please rebase the pr and check the expected output. |
Codecov Report
@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
+ Coverage 42.59% 42.65% +0.05%
==========================================
Files 73 73
Lines 7038 7062 +24
==========================================
+ Hits 2998 3012 +14
- Misses 3757 3763 +6
- Partials 283 287 +4
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…e changes for generate-coverage.sh file
The code coverage is being generated as it has been enabled at the openshift org level. So, I guess we do not need this PR. |
So, closing this PR. |
Fixes #1557
What kind of PR is this?
/kind bug
What does does this PR do / why we need it:
This PR enables code coverage reports in PRs
Which issue(s) this PR fixes:
Fixes #1557
How to test changes / Special notes to the reviewer:
Codecoverage reports should be seen with PRs.