Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Generate codecov reports for PRs #2418

Closed
wants to merge 2 commits into from

Conversation

kanchwala-yusuf
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf commented Nov 28, 2019

  1. Changes to .codecov.yml to enable code coverage reports
  2. Changes to generate-coverage.sh for fixing errors

Fixes #1557

What kind of PR is this?
/kind bug

What does does this PR do / why we need it:
This PR enables code coverage reports in PRs

Which issue(s) this PR fixes:

Fixes #1557

How to test changes / Special notes to the reviewer:
Codecoverage reports should be seen with PRs.

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M labels Nov 28, 2019
@kanchwala-yusuf kanchwala-yusuf changed the title 1. Changes to .codecov.yml to enable code coverage reports Generate codecov reports for PRs Nov 28, 2019
@kanchwala-yusuf
Copy link
Contributor Author

/test v4.3-integration-e2e-benchmark

@kanchwala-yusuf kanchwala-yusuf force-pushed the 1557 branch 2 times, most recently from cf5ee8a to fb11983 Compare November 29, 2019 06:29
@kanchwala-yusuf
Copy link
Contributor Author

/test v4.3-integration-e2e-benchmark

@kadel kadel removed the kind/bug Categorizes issue or PR as related to a bug. label Dec 2, 2019
@@ -5,7 +5,7 @@

set -e
echo "" > coverage.txt
go test -i -race ./cmd/odo
#go test -i -race ./cmd/odo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please remove this commented code?

.codecov.yml Outdated
@@ -1,10 +1,35 @@
codecov:
require_ci_to_pass: no

comment:
behavior: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default behavior updates the coverage info but when updating, the creation date of the comment will stay the same. There will be an edited link with a drop-down where you can check the times updated.
there is a new setting which deletes old and post new one. Would considering that be better @kanchwala-yusuf ?
cc @kadel

@kanchwala-yusuf kanchwala-yusuf changed the title Generate codecov reports for PRs [WIP] Generate codecov reports for PRs Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. labels Dec 3, 2019
@kanchwala-yusuf
Copy link
Contributor Author

@girishramnani, Forgot to add the WIP in the PR title. The changes in the PR are tentative and subject to change.

@kanchwala-yusuf
Copy link
Contributor Author

This PR requires codecov to be enabled at the openshift org level. @amitkrout is following the due procedure for the same.

Once, that is done, this PR can progress ahead.

cc: @kadel , @amitkrout

@kanchwala-yusuf kanchwala-yusuf added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Feb 4, 2020
@amitkrout
Copy link
Contributor

This PR requires codecov to be enabled at the openshift org level. @amitkrout is following the due procedure for the same. Once, that is done, this PR can progress ahead.

Created a jira task of priority Urgent in projects/DPP and shared it in fourum-dp-platform for a quick action

@amitkrout
Copy link
Contributor

amitkrout commented Feb 4, 2020

Created a jira task of priority Urgent in projects/DPP and shared it in fourum-dp-platform for a quick action

@kanchwala-yusuf This is the last update i got on the jira

Right after I posted this, I found an org-level setting where I had to explicitly grant 
CodeCov access to openshift/odo, so I enabled it. I think you should be good to go.

Seems the access has been granted. Can you please rebase the pr and check the expected output.

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #2418 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
+ Coverage   42.59%   42.65%   +0.05%     
==========================================
  Files          73       73              
  Lines        7038     7062      +24     
==========================================
+ Hits         2998     3012      +14     
- Misses       3757     3763       +6     
- Partials      283      287       +4
Impacted Files Coverage Δ
pkg/occlient/occlient.go 49.48% <0%> (-0.12%) ⬇️
pkg/occlient/volumes.go 73.83% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8725bb0...73bc879. Read the comment docs.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Feb 5, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cdrage
You can assign the PR to them by writing /assign @cdrage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

scripts/generate-coverage.sh Outdated Show resolved Hide resolved
.codecov.yml Show resolved Hide resolved
@kanchwala-yusuf
Copy link
Contributor Author

The code coverage is being generated as it has been enabled at the openshift org level. So, I guess we do not need this PR.

@kanchwala-yusuf
Copy link
Contributor Author

So, closing this PR.

@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person kind/bug Categorizes issue or PR as related to a bug. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test coverage is not reported on each pr
6 participants