Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor integration tests - BeforeEach #3221

Closed
wants to merge 12 commits into from
Closed

[WIP] Refactor integration tests - BeforeEach #3221

wants to merge 12 commits into from

Conversation

kadel
Copy link
Member

@kadel kadel commented May 20, 2020

What type of PR is this?

/kind cleanup
/kind test
/kind code-refactoring

What does this PR do / why we need it:
This tries to reduce code duplication in BeforeEach and AfterEach functions in our integrations tests

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/cleanup labels May 20, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kadel
You can assign the PR to them by writing /assign @kadel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel kadel force-pushed the refactor-before-each branch 4 times, most recently from cf0e457 to d87fae0 Compare May 20, 2020 16:56
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 21, 2020
@kadel kadel force-pushed the refactor-before-each branch 2 times, most recently from 9c5ac8e to 5dcddf5 Compare May 21, 2020 08:32
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 21, 2020
@kadel kadel force-pushed the refactor-before-each branch 2 times, most recently from 23ccb4f to 4e55409 Compare May 21, 2020 14:38
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 21, 2020
@kadel kadel force-pushed the refactor-before-each branch from 4e55409 to b6850cb Compare May 21, 2020 15:37
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 21, 2020
@kadel
Copy link
Member Author

kadel commented May 22, 2020

/retest

@kadel kadel force-pushed the refactor-before-each branch 5 times, most recently from b012054 to 8be01a2 Compare May 26, 2020 17:38
@amitkrout amitkrout mentioned this pull request May 27, 2020
Closed
@kadel kadel force-pushed the refactor-before-each branch from 8be01a2 to 6b3e07d Compare May 28, 2020 12:37
@kadel kadel force-pushed the refactor-before-each branch from 6b3e07d to 50720ab Compare May 29, 2020 11:47
@openshift-ci-robot
Copy link
Collaborator

@kadel: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.3-integration-e2e 50720ab link /test v4.3-integration-e2e
ci/prow/v4.5-integration-e2e 50720ab link /test v4.5-integration-e2e
ci/prow/v4.4-integration-e2e 50720ab link /test v4.4-integration-e2e
ci/prow/v4.2-integration-e2e 50720ab link /test v4.2-integration-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Collaborator

@kadel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 30, 2020
@prietyc123 prietyc123 mentioned this pull request Jun 3, 2020
Merged
@kadel kadel mentioned this pull request Jun 10, 2020
Closed
@kadel
Copy link
Member Author

kadel commented Jun 10, 2020

This needs to be done again and maybe in a better way.
I've opened #3337 to address the issue that this PR was trying to solve

/close

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closed this PR.

In response to this:

This needs to be done again and maybe in a better way.
I've opened #3337 to address the issue that this PR was trying to solve

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout Awaiting requested review from amitkrout

@dharmit dharmit Awaiting requested review from dharmit

Assignees
No one assigned
Labels
area/refactoring Issues or PRs related to code refactoring do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadel @openshift-ci-robot @rm3l @prietyc123