Imagestream error on experimental mode #3314
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
amitkrout
added
the
area/testing
amitkrout
force-pushed
the
imagestreamErrorOnExperimentalMode
branch
from
814c08f to
16c4c7c
Compare
| @@ -58,6 +58,14 @@ var _ = Describe("odo devfile create command tests", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Context("When executing odo create with incorrect devfile component", func() { | |||
There was a problem hiding this comment.
@amitkrout Does incorrect devfile and invalid differs? I think we do have spec for the same https://github.com/openshift/odo/pull/3314/files#diff-5291a6a42f2148d4c3e48ea4b73cff23R136 . Correct me if I am missing something.
There was a problem hiding this comment.
The original pr #3265 its clearly mentioned in the pr description that the component mane is invalid not incorrect. so I replaced invalid with incorrect to be in more sync with the original pr.
@prietyc123 Does it make sense now ?
There was a problem hiding this comment.
Yes, that's true we have invalid component name but what I mean is the spec that you are adding is duplicate of line no 136 https://github.com/openshift/odo/pull/3314/files#diff-5291a6a42f2148d4c3e48ea4b73cff23R136 .
There was a problem hiding this comment.
Ahhh...Got it. You know its the Monday effect hahaha...
amitkrout
force-pushed
the
imagestreamErrorOnExperimentalMode
branch
from
ae0a1b3 to
b26a2c0
Compare
|
@amitkrout: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
as per discussion, added changes of this PR on #3322 |
What type of PR is this?
missing integration test
What does does this PR do / why we need it:
Adding integration test coverage for imagestream error on experimental mode
Which issue(s) this PR fixes:
Fixes - missing integration test of #3265
How to test changes / Special notes to the reviewer:
make test-cmd-devfile-create