Fixes TestDownloadFile for go 1.14.2 #3434

mik-dass · 2020-06-26T14:25:16Z

What type of PR is this?

/kind bug

What does does this PR do / why we need it:

This PR fixes TestDownloadFile for go version go version go1.14.2 linux/amd64 by removing "" from the expected error string.

Which issue(s) this PR fixes:

Fixes #3433

How to test changes / Special notes to the reviewer:

make test should pass on go 1.14.2

amitkrout · 2020-06-29T05:31:07Z

@mik-dass Currently our odo release bits build on go 1.12 due to certain constraint in our internal build environment, so make sure that your change should not bring any last moment release failure surprises.

/hold

mik-dass · 2020-06-29T07:53:11Z

@mik-dass Currently our odo release bits build on go 1.12 due to certain constraint in our internal build environment, so make sure that your change should not bring any last moment release failure surprises.

Even our travis builds use 1.12+ and the tests have passed on travis.

amitkrout · 2020-06-29T11:22:57Z

@mik-dass Currently our odo release bits build on go 1.12 due to certain constraint in our internal build environment, so make sure that your change should not bring any last moment release failure surprises.

Even our travis builds use 1.12+ and the tests have passed on travis.

On Travis the exact go version is go version go1.12.17 linux/amd64 (https://travis-ci.com/github/openshift/odo/jobs/353970162#L193). @mohammedzee1000 can you please confirm the go version we use in our build env.

By seeing the go version in travis, i guess your changes will work on the version we use in brew build but for double sure can you please test your change on the build env go version once @mohammedzee1000 confirms.

mohammedzee1000 · 2020-06-30T10:08:22Z

@amitkrout currently it is 1.12 although new build env does provide us with go 1.13 so we should be moving to that in the near future.

I don't see any problems here as it does not seem to effect anything current. Get must no longer be present in error message in 1.14 and not having that in our check is fine as the rest of it is present. So this change is backward compatible

mohammedzee1000 · 2020-06-30T10:09:01Z

/hold cancel

kadel · 2020-06-30T11:19:00Z

@mik-dass Currently our odo release bits build on go 1.12 due to certain constraint in our internal build environment, so make sure that your change should not bring any last moment release failure surprises.

/hold

Why put this PR on hold? This doesn't change the minimal required Go version.

/approve
/lgtm

Small fix. Approving and lgtming

openshift-ci-robot · 2020-06-30T11:19:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kadel · 2020-06-30T11:20:01Z

/retest

level=fatal msg="failed to fetch Common Manifests: failed to fetch dependency of \"Common Manifests\": failed to generate asset \"DNS Config\": getting public zone for \"origin-ci-int-aws.dev.rhcloud.com\": listing hosted zones: Throttling: Rate exceeded\n\tstatus code: 400, request id: 35be24b2-8482-4b1d-9632-92230d20af89"

codecov · 2020-06-30T13:34:35Z

Codecov Report

Merging #3434 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3434      +/-   ##
==========================================
- Coverage   46.39%   46.36%   -0.03%     
==========================================
  Files         112      112              
  Lines       11233    11233              
==========================================
- Hits         5211     5208       -3     
- Misses       5517     5520       +3     
  Partials      505      505

Impacted Files	Coverage Δ
pkg/sync/sync.go	`45.54% <0.00%> (-2.98%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc7c33...8ad48b0. Read the comment docs.

amitkrout · 2020-06-30T14:17:43Z

@mik-dass Currently our odo release bits build on go 1.12 due to certain constraint in our internal build environment, so make sure that your change should not bring any last moment release failure surprises.
/hold

Why put this PR on hold? This doesn't change the minimal required Go version.

TBH i did not see the code change for it. When i see the pr title like updating something that will be compiled on go 1.14.0, which reminds me the last time failure on our internal release env having go 1.12.0. So i though instead of reviewing the code at first place, better to get confirmation from @mohammedzee1000 if this is doable.

openshift-bot · 2020-06-30T15:46:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T17:43:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T17:56:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T20:06:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T20:19:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T20:35:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T21:50:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T22:55:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-30T23:34:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T00:13:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T00:26:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T05:12:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T05:26:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T06:05:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T06:17:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T06:43:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T06:56:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T07:09:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T08:14:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T08:27:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T08:53:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T09:32:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T09:45:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T10:11:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T10:37:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T11:03:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T11:16:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T12:08:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T12:21:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T14:18:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-01T14:31:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-07-01T15:27:15Z

@mik-dass: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/v4.2-integration-e2e	`8ad48b0`	link	`/test v4.2-integration-e2e`
ci/prow/v4.3-integration-e2e	`8ad48b0`	link	`/test v4.3-integration-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-07-01T15:49:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

* Update Node test devfile Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Update node test template check in test Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * resolved devfile debug tests * revert devfile vol changes Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * removed unnecessary git clones * resolved serial debug test * resolved failing docker test Co-authored-by: Girish Ramnani <gramnani@redhat.com>

openshift-ci-robot · 2020-07-01T15:59:52Z

New changes are detected. LGTM label has been removed.

mik-dass · 2020-07-01T16:13:13Z

The commit 5ec8274 in #3291 resolved the issue. So this PR is not required anymore.
/close

openshift-ci-robot · 2020-07-01T16:13:29Z

@mik-dass: Closed this PR.

In response to this:

The commit 5ec8274 in #3291 resolved the issue. So this PR is not required anymore.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 26, 2020

openshift-ci-robot requested review from adisky and johnmcollier June 26, 2020 14:25

mik-dass force-pushed the fix_testDownloadFile branch from 0341b53 to 8ad48b0 Compare June 26, 2020 14:51

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jun 29, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jun 30, 2020

openshift-ci-robot assigned kadel Jun 30, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Jun 30, 2020

mik-dass force-pushed the fix_testDownloadFile branch from 8ad48b0 to 9210a18 Compare July 1, 2020 15:59

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 1, 2020

openshift-ci-robot closed this Jul 1, 2020

mik-dass deleted the fix_testDownloadFile branch July 1, 2020 16:14

Fixes TestDownloadFile for go 1.14.2 #3434

Fixes TestDownloadFile for go 1.14.2 #3434

Conversation

mik-dass commented Jun 26, 2020 • edited Loading

amitkrout commented Jun 29, 2020

mik-dass commented Jun 29, 2020

amitkrout commented Jun 29, 2020

mohammedzee1000 commented Jun 30, 2020 • edited Loading

mohammedzee1000 commented Jun 30, 2020

kadel commented Jun 30, 2020 • edited Loading

openshift-ci-robot commented Jun 30, 2020

kadel commented Jun 30, 2020

codecov bot commented Jun 30, 2020

Codecov Report

amitkrout commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jun 30, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-bot commented Jul 1, 2020

openshift-ci-robot commented Jul 1, 2020 • edited Loading

openshift-bot commented Jul 1, 2020

openshift-ci-robot commented Jul 1, 2020

mik-dass commented Jul 1, 2020

openshift-ci-robot commented Jul 1, 2020

mik-dass commented Jun 26, 2020 •

edited

Loading

mohammedzee1000 commented Jun 30, 2020 •

edited

Loading

kadel commented Jun 30, 2020 •

edited

Loading

openshift-ci-robot commented Jul 1, 2020 •

edited

Loading