Fix odo create interactive mode

[johnmcollier]

Signed-off-by: John Collier John.J.Collier@ibm.com

What type of PR is this?
/kind bug

What does does this PR do / why we need it:
This PR fixes interactive mode for devfiles. It seems a recent change that was delivered used a short assignment operator (:=) to assign a value to the catalogDevfileList variable, which caused a local-scoped version of it to get created in the if-block. This meant the value of catalogDevfileList couldn't be seen outside of the if-statement (despite the variable being declared outside it)

Which issue(s) this PR fixes:

Fixes #3436

How to test changes / Special notes to the reviewer:
odo create

[johnmcollier]

/hold cause this directly conflicts with @maysunfaisal's command group PR #3291

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cdrage
You can assign the PR to them by writing /assign @cdrage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[GeekArthur]

Good catch, I can review and approve this once #3291 merges in.

[openshift-ci-robot]

@johnmcollier: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/v4.2-integration-e2e	680b29c	link	/test v4.2-integration-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[maysunfaisal]

@johnmcollier this is actually getting fixed with #3291

[johnmcollier]

@maysunfaisal Ah, good catch. But, interactive mode is broken on your PR it seems:

[johnmcollier]

@maysunfaisal I've updated the PR description for #3291 to include #3436 as a fixed issue.

[maysunfaisal]

@johnmcollier yeah I should have opened issues earlier to keep track. There was one more issue with interactive mode that I am forgetting but its fixed by #3291