New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added deprecation and error messages for 'odo update` #3453

Merged

openshift-merge-robot merged 1 commit into redhat-developer:master from devang-gaur:issue3396

Jul 11, 2020

Contributor

devang-gaur commented Jun 30, 2020 •

edited

Loading

/kind deprecation

What does does this PR do / why we need it:
added deprecation and error messages for odo update

Which issue(s) this PR fixes:
Fixes #3396

How to test changes / Special notes to the reviewer:
run odo update for 1. s2i components (expect a deprecation warning)
2. devfile component (expect an error)

Its a Draft right now

devang-gaur added the area/component label

openshift-ci-robot requested review from girishramnani and prietyc123

June 30, 2020 12:12

devang-gaur marked this pull request as draft

June 30, 2020 13:03

openshift-ci-robot added the do-not-merge/work-in-progress label

devang-gaur changed the title ~~added deprecation and error messages for~~ added deprecation and error messages for 'odo update`

devang-gaur force-pushed the issue3396 branch from 7d6dedd to a4e1ca5 Compare

July 2, 2020 13:29

codecov bot commented Jul 2, 2020 •

edited

Loading

Codecov Report

Merging #3453 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3453      +/-   ##
==========================================
- Coverage   46.51%   46.45%   -0.06%     
==========================================
  Files         112      112              
  Lines       11223    11237      +14     
==========================================
  Hits         5220     5220              
- Misses       5504     5513       +9     
- Partials      499      504       +5

Impacted Files	Coverage Δ
pkg/sync/sync.go	`43.56% <0.00%> (-5.95%)`	⬇️
pkg/devfile/adapters/kubernetes/utils/utils.go	`52.48% <0.00%> (-1.93%)`	⬇️
pkg/devfile/adapters/docker/component/utils.go	`68.83% <0.00%> (-0.68%)`	⬇️
...g/devfile/adapters/kubernetes/component/adapter.go	`29.62% <0.00%> (-0.13%)`	⬇️
pkg/lclient/client.go	`0.00% <0.00%> (ø)`
pkg/lclient/fakeclient.go	`82.11% <0.00%> (ø)`
pkg/devfile/adapters/common/types.go	`100.00% <0.00%> (ø)`
pkg/devfile/adapters/docker/component/adapter.go	`74.01% <0.00%> (+0.20%)`	⬆️
pkg/sync/adapter.go	`82.88% <0.00%> (+1.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a73e3...547507c. Read the comment docs.

devang-gaur force-pushed the issue3396 branch from a4e1ca5 to 547507c Compare

July 3, 2020 21:56

devang-gaur removed the do-not-merge/work-in-progress label

girishramnani added the do-not-merge/work-in-progress label

Contributor

girishramnani commented Jul 8, 2020

adding WIP in the label as this is still draft PR

Contributor

girishramnani commented Jul 8, 2020

@dev-gaur please make this as non-draft PR by clicking the Ready for review button

devang-gaur marked this pull request as ready for review

July 8, 2020 22:59

openshift-ci-robot removed the do-not-merge/work-in-progress label

devang-gaur force-pushed the issue3396 branch from 547507c to 20660ac Compare

July 9, 2020 02:01

devang-gaur mentioned this pull request

cleanup #3403: removed --memory, --min-memory. --max-memory, --cpu, --min-cpu, --max-cpu flags from 'odo create' command #3475

Merged

adisky reviewed

View reviewed changes

pkg/odo/cli/component/update.go Outdated

               	  %[1]s --binary ./downloads/sample.war
               		`)
+              const deprecationWarning string = "WARNING: 'odo update' command will be removed in the future odo version.\n" +
+              	"You should be using `odo config` command instead.\n" +

Contributor

adisky Jul 9, 2020

I think we should add the same warning in odo update --help
Also can we change the color of message to yellow?

Contributor Author

devang-gaur Jul 10, 2020

changes made.

Contributor

girishramnani commented Jul 10, 2020

Please address @adisky , everything else good.
/approve

Collaborator

openshift-ci-robot commented Jul 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

devang-gaur force-pushed the issue3396 branch from 20660ac to b3a2c0a Compare

July 10, 2020 10:23

devang-gaur requested a review from adisky

July 10, 2020 10:24


          added deprecation and error messages for 'odo update'

b6d8fad

devang-gaur force-pushed the issue3396 branch from b3a2c0a to b6d8fad Compare

July 10, 2020 13:24

Contributor

girishramnani commented Jul 11, 2020

/lgtm

openshift-ci-robot assigned girishramnani

openshift-ci-robot added the lgtm label

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

28 similar comments

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 4d69aab into redhat-developer:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels