Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node devfile tests #3459

Merged
merged 7 commits into from
Jul 1, 2020
Merged

Update Node devfile tests #3459

merged 7 commits into from
Jul 1, 2020

Conversation

maysunfaisal
Copy link
Contributor

Signed-off-by: Maysun J Faisal maysun.j.faisal@ibm.com

What type of PR is this?
/kind failing-test

What does does this PR do / why we need it:
tests broken by odo-devfiles/registry#7

Which issue(s) this PR fixes:

Fixes N/A

How to test changes / Special notes to the reviewer:
Run the CI

@maysunfaisal
Update Node test devfile
cc3637f 
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
@girishramnani girishramnani self-requested a review June 30, 2020 21:22
maysunfaisal and others added 5 commits June 30, 2020 17:31
@maysunfaisal
Update node test template check in test
5519e03 
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
resolved devfile debug tests
dd1ce1b
@maysunfaisal
revert devfile vol changes
b11d27e 
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
removed unnecessary git clones
7776567
resolved serial debug test
ffe1dd0
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 1, 2020
@girishramnani
Copy link
Contributor

/retest

1 similar comment
@girishramnani
Copy link
Contributor

/retest

mik-dass
mik-dass approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green and the changes look good to me
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 1, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@girishramnani girishramnani mentioned this pull request Jul 1, 2020
Closed
@prietyc123 prietyc123 mentioned this pull request Jul 1, 2020
Closed
@girishramnani
Copy link
Contributor

@prietyc123 please update the description so that the linked issues get closed

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #3459 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
- Coverage   46.50%   46.49%   -0.01%     
==========================================
  Files         112      112              
  Lines       11223    11223              
==========================================
- Hits         5219     5218       -1     
- Misses       5503     5504       +1     
  Partials      501      501
Impacted Files Coverage Δ
pkg/sync/sync.go 47.52% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bba03...594e907. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 72996e0 into redhat-developer:master Jul 1, 2020
mik-dass pushed a commit to mik-dass/odo that referenced this pull request Jul 1, 2020
@maysunfaisal @mik-dass
Update Node devfile tests (redhat-developer#3459)
9210a18 
* Update Node test devfile

Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>

* Update node test template check in test

Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>

* resolved devfile debug tests

* revert devfile vol changes

Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>

* removed unnecessary git clones

* resolved serial debug test

* resolved failing docker test

Co-authored-by: Girish Ramnani <gramnani@redhat.com>
@dharmit dharmit mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@adisky adisky Awaiting requested review from adisky

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maysunfaisal @girishramnani @openshift-ci-robot @openshift-bot @mik-dass @openshift-merge-robot