add container name validation during creation and push

pkg/odo/cli/component/create.go

@@ -18,6 +18,7 @@ import (
 	"github.com/openshift/odo/pkg/component"
 	"github.com/openshift/odo/pkg/config"
 	"github.com/openshift/odo/pkg/devfile"
+	adaptersCommon "github.com/openshift/odo/pkg/devfile/adapters/common"
 	"github.com/openshift/odo/pkg/devfile/parser"
 	"github.com/openshift/odo/pkg/devfile/parser/data/common"
 	"github.com/openshift/odo/pkg/envinfo"
@@ -835,13 +836,13 @@ func (co *CreateOptions) Validate() (err error) {
 		if err != nil {
 			return err
 		}
-
 		// Only validate namespace if pushtarget isn't docker
 		if !pushtarget.IsPushTargetDocker() {
 			err := util.ValidateK8sResourceName("component namespace", co.devfileMetadata.componentNamespace)
 			if err != nil {
 				return err
 			}
+
 		}
 
 		spinner.End(true)
@@ -1062,6 +1063,13 @@ func (co *CreateOptions) devfileRun() (err error) {
 	if err != nil {
 		return errors.Wrap(err, "unable to parse devfile")
 	}
+	containerComponents := adaptersCommon.GetDevfileContainerComponents(devObj.Data)
+	for _, comp := range containerComponents {
+		err := util.ValidateK8sResourceName("container name", comp.Name)
+		if err != nil {
+			return err
+		}
+	}
 
 	err = downloadStarterProject(devObj, co.devfileMetadata.starter, co.interactive)
 	if err != nil {

pkg/odo/cli/component/push.go

@@ -10,6 +10,7 @@ import (
 	ktemplates "k8s.io/kubectl/pkg/util/templates"
 
 	"github.com/openshift/odo/pkg/component"
+	adaptersCommon "github.com/openshift/odo/pkg/devfile/adapters/common"
 	"github.com/openshift/odo/pkg/devfile/parser"
 	"github.com/openshift/odo/pkg/log"
 	projectCmd "github.com/openshift/odo/pkg/odo/cli/project"
@@ -175,6 +176,28 @@ func (po *PushOptions) Validate() (err error) {
 	// If Devfile is present we do not need to validate the below S2I checks
 	// TODO: Perhaps one day move Devfile validation to here instead?
 	if util.CheckPathExists(po.DevfilePath) {
+		spinner := log.Spinner("Validating devfile component")
+		defer spinner.End(false)
+		err = util.ValidateK8sResourceName("component name", po.EnvSpecificInfo.GetName())
+		if err != nil {
+			return err
+		}
+		containerComponents := adaptersCommon.GetDevfileContainerComponents(po.Devfile.Data)
+		for _, comp := range containerComponents {
+			err := util.ValidateK8sResourceName("container name", comp.Name)
+			if err != nil {
+				return err
+			}
+		}
+		// Only validate namespace if pushtarget isn't docker
+		if !pushtarget.IsPushTargetDocker() {
+			err := util.ValidateK8sResourceName("component namespace", po.EnvSpecificInfo.GetNamespace())
+			if err != nil {
+				return err
+			}
+		}
+
+		spinner.End(true)
 		return nil
 	}
 

tests/integration/devfile/cmd_devfile_create_test.go

@@ -198,6 +198,12 @@ var _ = Describe("odo devfile create command tests", func() {
 				helper.CmdShouldFail("odo", "create", "nodejs", "--devfile", "/path/to/file")
 			})
 
+			It("should fail to create the devfile component if the container name is too long", func() {
+				helper.ReplaceString("devfile.yaml", "runtime", "runtimeruntimeruntimeruntimeruntimeruntimeruntimeruntimeruntimeruntime")
+				output := helper.CmdShouldFail("odo", "create", "--devfile", "./devfile.yaml")
+				Expect(output).Should(ContainSubstring("Contain at most 63 characters"))
+			})
+
 			It("should fail to create the devfile component for an invalid devfile", func() {
 				// Delete the devfile that was copied in as part of setup
 				helper.DeleteFile("devfile.yaml")

tests/integration/devfile/cmd_devfile_env_test.go

@@ -13,7 +13,7 @@ import (
 var _ = Describe("odo devfile env command tests", func() {
 	const (
 		testName      = "testname"
-		testNamepace  = "testNamepace"
+		testNamepace  = "testnamepace"
 		testDebugPort = "8888"
 		fakeParameter = "fakeParameter"
 	)

tests/integration/devfile/cmd_devfile_push_test.go

@@ -648,6 +648,17 @@ var _ = Describe("odo devfile push command tests", func() {
 			helper.MatchAllInOutput(output, []string{"no POM in this directory"})
 		})
 
+		It("should fail to push the devfile component if the container name is too long", func() {
+
+			helper.CmdShouldPass("odo", "create", "nodejs", "--project", namespace, cmpName)
+
+			helper.CopyExample(filepath.Join("source", "devfiles", "nodejs", "project"), context)
+			helper.CopyExampleDevFile(filepath.Join("source", "devfiles", "nodejs", "devfile.yaml"), filepath.Join(context, "devfile.yaml"))
+			helper.ReplaceString("devfile.yaml", "runtime", "runtimeruntimeruntimeruntimeruntimeruntimeruntimeruntimeruntimeruntime")
+			output := helper.CmdShouldFail("odo", "push", "--context", context)
+			Expect(output).Should(ContainSubstring("Contain at most 63 characters"))
+		})
+
 	})
 
 	Context("Verify files are correctly synced", func() {