Use latest alizer library version, including .net detection #5804
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
the
kind/feature
There was a problem hiding this comment.
LGTM.
As discussed in https://github.com/redhat-developer/odo/pull/5774/files#r885866357, maybe we could now also update the Quickstart Guide for .NET to include a more realistic sample output? Could be done here or in a subsequent PR.
cc @cdrage
openshift-ci
bot
added
the
lgtm
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
I updated the doc, but Alizer does not detect the version of dotnet in this case. |
|
I am inclined to approve this because the updated library detects the language correctly if not the version, unlike the current library version that we have in main. I have a dotnet 3.1 project here. ➜ ls
app.csproj appsettings.Development.json appsettings.json Controllers Models Program.cs Properties Startup.cs Views wwwroot
➜ cat app.csproj
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
</PropertyGroup>
</Project>Result from main: ➜ odo init
__
/ \__ Initializing new component
\__/ \ Files: Source code detected, a Devfile will be determined based upon source code autodetection
/ \__/ odo version: v3.0.0-alpha3
\__/
Interactive mode enabled, please answer the following questions:
Based on the files in the current directory odo detected
Language: javascript
Project type: nodejs
The devfile "nodejs" from the registry "MyRegistry" will be downloaded.
? Is this correct? No
^CResult from updated library: ➜ odo init
__
/ \__ Initializing new component
\__/ \ Files: Source code detected, a Devfile will be determined based upon source code autodetection
/ \__/ odo version: v3.0.0-alpha2
\__/
Interactive mode enabled, please answer the following questions:
Based on the files in the current directory odo detected
Language: dotnet
Project type: dotnet
The devfile "dotnet50" from the registry "MyRegistry" will be downloaded.
? Is this correct? (Y/n)
✗ interrupt
the command failed, the devfile has been removed from current directoryThe updated version does not detect the version properly, it always goes with dotnet50, I tested with dotnet 6 as well. But it detects the language better than the previous version. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.10-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Great - thanks for the changes. Maybe we can open an issue in the Alizer repo then? |
…eveloper#5804) * Use latest alizer library version * Update quickstart guide
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5803
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: