Fix: (odo list) Empty parenthesis for odo version if component is not on the cluster #6078
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold Based on the files in the current directory odo detected
Language:
Project type:
The devfile "a-devfile-name" from the registry "a-registry" will be downloaded.
Based on the files in the current directory odo detected
Language:
Project type:
The devfile "" from the registry "" will be downloaded.
--- FAIL: TestInteractiveBackend_PersonalizeName (6.44s)
--- FAIL: TestInteractiveBackend_PersonalizeName/no_flag (6.44s)
controller.go:137: missing call(s) to *asker.MockAsker.AskName(is anything) /go/src/github.com/redhat-developer/odo/pkg/init/backend/interactive_test.go:223
controller.go:137: aborting test due to missing call(s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x26b3592]
goroutine 101 [running]:
testing.tRunner.func1.2({0x30ce1e0, 0x496e500})
/usr/local/go/src/testing/testing.go:1209 +0x36c
testing.tRunner.func1()
/usr/local/go/src/testing/testing.go:1212 +0x3b6
panic({0x30ce1e0, 0x496e500})
/usr/local/go/src/runtime/panic.go:1047 +0x266
github.com/redhat-developer/alizer/go/pkg/apis/recognizer.GetFilePathsFromRoot.func1({0xc0007a3011, 0xf}, {0x0, 0x0}, {0xc00078f070, 0xc000c2e0d0})
/go/src/github.com/redhat-developer/odo/vendor/github.com/redhat-developer/alizer/go/pkg/apis/recognizer/language_recognizer.go:125 +0x132
path/filepath.walk({0x333268b, 0x4}, {0x378e5e0, 0xc000c2e0d0}, 0xc000bdf070)
/usr/local/go/src/path/filepath/path.go:438 +0x2a3
path/filepath.Walk({0x333268b, 0x4}, 0xc00078f070)
/usr/local/go/src/path/filepath/path.go:505 +0x85
github.com/redhat-developer/alizer/go/pkg/apis/recognizer.GetFilePathsFromRoot({0x333268b, 0x4})
/go/src/github.com/redhat-developer/odo/vendor/github.com/redhat-developer/alizer/go/pkg/apis/recognizer/language_recognizer.go:116 +0xdf
github.com/redhat-developer/alizer/go/pkg/apis/recognizer.Analyze({0x333268b, 0x4})
/go/src/github.com/redhat-developer/odo/vendor/github.com/redhat-developer/alizer/go/pkg/apis/recognizer/language_recognizer.go:36 +0x158
github.com/redhat-developer/alizer/go/pkg/apis/recognizer.detectComponent({0x333268b, 0x4}, {0xc000bdf918, 0x0, 0x0})
/go/src/github.com/redhat-developer/odo/vendor/github.com/redhat-developer/alizer/go/pkg/apis/recognizer/component_recognizer.go:237 +0x9a
github.com/redhat-developer/alizer/go/pkg/apis/recognizer.getComponentsWithoutConfigFile({0xc000597250, 0x1, 0x0})
/go/src/github.com/redhat-developer/odo/vendor/github.com/redhat-developer/alizer/go/pkg/apis/recognizer/component_recognizer.go:66 +0xee
github.com/redhat-developer/alizer/go/pkg/apis/recognizer.DetectComponents({0x333268b, 0x4})
/go/src/github.
github.com/redhat-developer/odo/pkg/alizer.DetectName({0x333268b, 0x4})
/go/src/github.
com/redhat-developer/odo/pkg/alizer/alizer.go:92 +0x94
github.com/redhat-developer/odo/pkg/init/backend.(*InteractiveBackend).PersonalizeName(0xc000bdfd38, {{{0x0, 0x0}, {0x333268b, 0x11}, {0x0, 0x0}, {0x0, 0x0, 0x0}, ...}, ...}, ...)
/go/src/github.com/redhat-developer/odo/pkg/init/backend/interactive.go:126 +0x69
github.com/redhat-developer/odo/pkg/init/backend.TestInteractiveBackend_PersonalizeName.func4(0xc0000ea4e0)
/go/src/github.com/redhat-developer/odo/pkg/init/backend/interactive_test.go:256 +0x2ca
testing.tRunner(0xc0000ea4e0, 0xc000457cd0)
/usr/local/go/src/testing/testing.go:1259 +0x230
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1306 +0x727
FAIL github.com/redhat-developer/odo/pkg/init/backend 6.925s |
openshift-ci
bot
added
the
do-not-merge/hold
This has been reported in #6092, and should be fixed by #6093 - thanks @feloy ! |
Oh. It passes on the main branch, so I figured it was something with my PR. I'll cancel the hold then. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override Kubernetes Integration Tests/Kubernetes Integration Tests |
|
@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/unit-and-validate-test |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/unit-and-validate-test, ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override Kubernetes Integration Tests/Kubernetes Integration Tests |
|
@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override "Kubernetes Integration Tests/Kubernetes Integration Tests" |
|
@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
valaparthvi
force-pushed
the
list-fix
branch
from
f3a8010
to
de3c3c9
Compare
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/unit-and-validate-test /override windows-integration-test/Windows-test |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test, windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/v4.10-integration-e2e IBM tests have passed. |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
valaparthvi
force-pushed
the
list-fix
branch
from
de3c3c9
to
bbef5fb
Compare
openshift-ci
bot
removed
the
lgtm
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… running on the cluster Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
list-fix
branch
from
bbef5fb
to
8d3569f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.10-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6061
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
mkdir /tmp/101; cd /tmp/101odo init --devfile go --name my-go --starter go-starterodo listshould not show empty parenthesis for odo version