Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for Ephemeral in documentation #6102

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Sep 7, 2022

What type of PR is this:
/kind documentation

What does this PR do / why we need it:
Since #5795, the default value for 'Ephemeral' is now False, but the documentation was outdated.

Which issue(s) this PR fixes:
No issue related

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Since redhat-developer#5795, the default value is now False,
but the documentation was outdated.
@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 63dd7e4
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/631873f1c329520008717ddb
😎 Deploy Preview https://deploy-preview-6102--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from feloy and kadel September 7, 2022 10:35
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 7, 2022
@odo-robot
Copy link

odo-robot bot commented Sep 7, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2022

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Sep 7, 2022

/override windows-integration-test/Windows-test

Doc only

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Doc only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f73a5be into redhat-developer:main Sep 7, 2022
@rm3l rm3l deleted the update_ephemeral_default_value_in_website branch September 7, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants