-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default value for Ephemeral
in documentation
#6102
Fix default value for Ephemeral
in documentation
#6102
Conversation
Since redhat-developer#5795, the default value is now False, but the documentation was outdated.
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override windows-integration-test/Windows-test Doc only |
@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind documentation
What does this PR do / why we need it:
Since #5795, the default value for 'Ephemeral' is now
False
, but the documentation was outdated.Which issue(s) this PR fixes:
No issue related
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: