Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make command reference docs consistent (2) #6153

Merged

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind documentation
/area documentation

What does this PR do / why we need it:
This PR adds missing data.
Which issue(s) this PR fixes:

Fixes #6000

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 8ad74c5
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/632aed138637fc0008b950ff
😎 Deploy Preview https://deploy-preview-6153--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/documentation area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Sep 21, 2022
@openshift-ci openshift-ci bot requested review from cdrage and kadel September 21, 2022 10:53
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Sep 21, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 21, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 21, 2022

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 21, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 21, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
Docs PR.

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
Docs PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cdrage
Copy link
Member

cdrage commented Sep 22, 2022

Looks great! Thank you for going through command reference and figuring out what needs updating.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 22, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit c1bb752 into redhat-developer:main Sep 23, 2022
kadel pushed a commit to kadel/odo that referenced this pull request Oct 3, 2022
* Add collapsible examples

* Add examples to missing command reference docs

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Signed-off-by: Parthvi Vala <pvala@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make command reference docs consistent
4 participants