Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build context as part of GenericRun #6202

Merged
merged 34 commits into from
Oct 19, 2022
Merged

Build context as part of GenericRun #6202

merged 34 commits into from
Oct 19, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 7, 2022 •
edited
Loading

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6186 , #5517

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 7, 2022
@netlify
Copy link

netlify bot commented Oct 7, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 1788611
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6347d12eb594690008739b3f

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

@feloy: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6186

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Oct 7, 2022 •
edited
Loading

Unit Tests on commit e6e9853 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 7, 2022 •
edited
Loading

Windows Tests (OCP) on commit e6e9853 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 7, 2022 •
edited
Loading

Validate Tests on commit e6e9853 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 7, 2022 •
edited
Loading

Kubernetes Tests on commit e6e9853 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 7, 2022 •
edited
Loading

OpenShift Tests on commit e6e9853 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6186/generic-context branch from c7fb4e6 to 0be8b4c Compare October 10, 2022 11:35
@feloy feloy force-pushed the feature-6186/generic-context branch from 0be8b4c to e046573 Compare October 10, 2022 12:02
@feloy feloy force-pushed the feature-6186/generic-context branch from 57c5bde to 78631ba Compare October 11, 2022 07:46
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 14, 2022
@feloy feloy closed this Oct 14, 2022
@feloy feloy reopened this Oct 14, 2022
@feloy feloy closed this Oct 17, 2022
@feloy feloy reopened this Oct 17, 2022
@feloy feloy closed this Oct 17, 2022
@feloy feloy reopened this Oct 17, 2022
@feloy feloy closed this Oct 17, 2022
@feloy feloy reopened this Oct 17, 2022
@valaparthvi valaparthvi reopened this Oct 17, 2022
@feloy feloy closed this Oct 17, 2022
@feloy feloy reopened this Oct 17, 2022
@valaparthvi valaparthvi added kind/code-refactoring area/odo-on-podman Issues or PRs related to running odo against Podman labels Oct 18, 2022
@valaparthvi valaparthvi reopened this Oct 18, 2022
@feloy feloy closed this Oct 18, 2022
@feloy feloy reopened this Oct 18, 2022
@feloy feloy closed this Oct 18, 2022
@feloy feloy reopened this Oct 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@dharmit
Copy link
Member

dharmit commented Oct 19, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 19, 2022
@dharmit
Copy link
Member

dharmit commented Oct 19, 2022

/override ci/prow/v4.11-integration-e2e

because the tests are passing on IBM Cloud.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

because the tests are passing on IBM Cloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a2345c3 into redhat-developer:main Oct 19, 2022
@feloy feloy mentioned this pull request Feb 15, 2023
Closed
1 task
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/odo-on-podman Issues or PRs related to running odo against Podman area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build the Context as part of the GenericRun
5 participants
@feloy @dharmit @rm3l @valaparthvi @openshift-merge-robot