Fix rpminspect specname inspection failure

[rm3l]

What type of PR is this:
/kind bug
/area release-eng

What does this PR do / why we need it:
To anticipate the sunsetting of rpmdiff (replaced by rpminspect), this
makes sure that the odo RPM package passes rpminspect's inspections.
The only error reported when testing it was about an invalid spec
filename.

specname:
---------
1) Spec filename does not exactly match the primary name odo; got
'openshift-odo.spec'

Result: BAD
Waiver Authorization: Not Waivable

Suggested Remedy: The spec file name does not match the expected
NAME.spec
format.  Rename the spec file to conform to this policy.

See
https://docs.google.com/document/d/1PolwQHoZzf0oeOUN1IK7T_NDRAay-nurwL0xYj2JuOo/edit#
for more details about this.

Note
I am also about to submit a Merge Request to the internal release repo, as I saw some occurrences of this spec file there.
EDIT: See MR 71 in the internal release repository.

Which issue(s) this PR fixes:
Fixes #6213

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

It would be ideal to test this in CI, to prevent further regressions on this or any other inspections, but this is not possible at this time.
So we need to check manually:

# Build a local RPM
./scripts/rpm-prepare.sh && ./scripts/rpm-local-build.sh

# Install rpminspect tool and a data package (like rpminspect-redhat)
# More instructions on
# https://docs.google.com/document/d/1PolwQHoZzf0oeOUN1IK7T_NDRAay-nurwL0xYj2JuOo/edit#heading=h.kr9uelhdllk

# Run rpminspect locally
rpminspect-redhat -v -T specname ./dist/rpmbuild/SRPMS/odo-3.1.0-1.fc36.src.rpm

# You might optionally submit a Scratch build to make sure everything works correctly
See https://docs.google.com/document/d/1PolwQHoZzf0oeOUN1IK7T_NDRAay-nurwL0xYj2JuOo/edit#heading=h.9ihjiiivyk7z

[netlify]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	95ecaa9
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63621f2dc24cec0008eeaab2

[odo-robot]

Unit Tests on commit 7e36503 finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit 7e36503 finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit 7e36503 finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit 7e36503 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit 7e36503 finished successfully.
View logs: TXT HTML

[dharmit]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dharmit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rm3l]

Rebased and force-pushed to get fixes for the tests.

[odo-robot]

NoCluster Tests on commit 7e36503 finished successfully.
View logs: TXT HTML

[rm3l]

level=fatal msg=failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-gzchqyvb-c362a.origin-ci-int-aws.dev.rhcloud.com. (A), \052.apps.ci-op-gzchqyvb-c362a.origin-ci-int-aws.dev.rhcloud.com. (A)]

/test v4.11-integration-e2e

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[dharmit]

Seeing infra error again

/test v4.11-integration-e2e
/lgtm