Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize environment configuration #6293

Merged
merged 21 commits into from
Nov 17, 2022
Merged

Centralize environment configuration #6293

merged 21 commits into from
Nov 17, 2022

Commits on Nov 17, 2022

  1. Define central config

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    876d558 View commit details
    Browse the repository at this point in the history

  2. Use envConfig in GenericRun for segment parameters

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9d08217 View commit details
    Browse the repository at this point in the history

  3. Pass the env config into the context passed to CLI methods

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    893027d View commit details
    Browse the repository at this point in the history

  4. Use PodmanCmd and DockerCmd from context

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    62e020e View commit details
    Browse the repository at this point in the history

  5. Remove tests now that ODO_DISABLE_TELEMETRY is checked for a bool value

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    39715f1 View commit details
    Browse the repository at this point in the history

  6. deploy.Deploy: Use values from ctx instead of parameters + use FS fro… 

    …m DI
    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    02ac80a View commit details
    Browse the repository at this point in the history

  7. dev.Start: Use values from ctx instead of parameters

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    cfa6237 View commit details
    Browse the repository at this point in the history

  8. image.Build*: Use values from ctx instead of parameters

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    a94bb17 View commit details
    Browse the repository at this point in the history

  9. Use telemetry file from context

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    391127f View commit details
    Browse the repository at this point in the history

  10. Pass ctx to segment.getTelemetryForDevfileRegistry

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    a9ac24f View commit details
    Browse the repository at this point in the history

  11. Use ctx in getTelemetryForDevfileRegistry

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    7d86a6d View commit details
    Browse the repository at this point in the history

  12. Call IsTelemetryEnabled once and use scontext.GetTelemetryStatus after

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    8970758 View commit details
    Browse the repository at this point in the history

  13. Fix unit tests

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    4836d97 View commit details
    Browse the repository at this point in the history

  14. Use envConfig in segment.IsTelemetryEnabled

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    7f0ab80 View commit details
    Browse the repository at this point in the history

  15. Define TelemetryCaller constant in test helper

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    fd27700 View commit details
    Browse the repository at this point in the history

  16. IsTrackingConsentEnabled: get value from envconfig instead of env

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    2b1f24e View commit details
    Browse the repository at this point in the history

  17. Use ctx instead of GLOBALODOCONFIG

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    0bdb729 View commit details
    Browse the repository at this point in the history

  18. Place ODO_EXPERIMENTAL_MODE in configuration

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    1fc788e View commit details
    Browse the repository at this point in the history

  19. Use maintained envconfig package

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    44c78c4 View commit details
    Browse the repository at this point in the history

  20. Define default values when exist

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    51cbfaf View commit details
    Browse the repository at this point in the history

  21. Document accepted boolean values

    @feloy
    feloy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    e0a7f88 View commit details
    Browse the repository at this point in the history