-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InterOP: enable test report generation for tests #6307
InterOP: enable test report generation for tests #6307
Conversation
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you add all those XML report files to .gitignore
as well? This will prevent committing them accidentally to the repo after running those make
targets.
Or generate them into the reports
directory instead (taking care of creating the folder if it does not exist). I see we already have a reports
directory listed in .gitignore
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
/test v4.11-integration-e2e |
Retriggering the tests... |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/override ci/prow/v4.11-integration-e2e Tests passing on IBM Cloud. |
@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: anandrkskd anandrkskd@gmail.com
What type of PR is this:
/kind tests
What does this PR do / why we need it:
As we are want to start InterOP testing for v3, we need to start test reports generation.
Which issue(s) this PR fixes:
Fixes #
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: