Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for odo dev running on podman #6332

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Integration tests for odo dev running on podman #6332

merged 4 commits into from
Nov 24, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 22, 2022 •
edited
Loading

What type of PR is this:

/kind tests

What does this PR do / why we need it:

This PR defines a new Makefile entry

make test-integration-podman

that will run 5 integration tests featuring podman integration.

A system with a podman command line is necessary to run these tests.

Which issue(s) this PR fixes:

Fixes partially #6236

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 22, 2022
@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 59f9c7d
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637e3831b462bf0009cc1c07
😎 Deploy Preview https://deploy-preview-6332--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

NoCluster Tests on commit 7b94215 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Unit Tests on commit 7b94215 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Validate Tests on commit 7b94215 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Windows Tests (OCP) on commit 7b94215 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Kubernetes Tests on commit 7b94215 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

OpenShift Tests on commit 7b94215 finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [WIP] Change signature of StartDevMode to use options structure [WIP] Integration tests for odo dev running on podman Nov 22, 2022
@feloy feloy closed this Nov 23, 2022
@feloy feloy reopened this Nov 23, 2022
@feloy feloy changed the title [WIP] Integration tests for odo dev running on podman Integration tests for odo dev running on podman Nov 23, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy feloy closed this Nov 23, 2022
@feloy feloy reopened this Nov 23, 2022
rm3l
rm3l requested changes Nov 23, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
tests/integration/cmd_dev_test.go Outdated Show resolved Hide resolved
feloy and others added 2 commits November 23, 2022 16:10
@feloy
Uncomment commented code
6f9c5fc
@feloy @rm3l
Update Makefile
59f9c7d 
Co-authored-by: Armel Soro <armel@rm3l.org>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 23, 2022
@valaparthvi valaparthvi reopened this Nov 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

rm3l
rm3l reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 24, 2022
@feloy
Copy link
Contributor Author

feloy commented Nov 24, 2022

/override ci/prow/v4.11-integration-e2e
Pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 120920f into redhat-developer:main Nov 24, 2022
This was referenced Nov 25, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feloy @rm3l @valaparthvi @openshift-merge-robot