Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky test on Windows #6341

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Disable flaky test on Windows #6341

merged 1 commit into from
Nov 24, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 23, 2022 •
edited
Loading

What type of PR is this:

/kind tests

What does this PR do / why we need it:

This test fails on Windows because of the terminal emulator behaviour.

Which issue(s) this PR fixes:

Fixes #6327

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Nov 23, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 6022e6a
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637e6dcf617f2300098f0bd9

@odo-robot
Copy link

odo-robot bot commented Nov 23, 2022 •
edited
Loading

NoCluster Tests on commit 4c119ad finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 23, 2022 •
edited
Loading

Unit Tests on commit 4c119ad finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 23, 2022 •
edited
Loading

Validate Tests on commit 4c119ad finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 23, 2022 •
edited
Loading

Windows Tests (OCP) on commit 4c119ad finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 23, 2022 •
edited
Loading

Kubernetes Tests on commit 4c119ad finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 23, 2022 •
edited
Loading

OpenShift Tests on commit 4c119ad finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the fix-6327/flaky-test-windows branch 3 times, most recently from 2bf13a9 to 6050970 Compare November 23, 2022 18:16
@feloy feloy force-pushed the fix-6327/flaky-test-windows branch from 6050970 to 6022e6a Compare November 23, 2022 19:00
@feloy feloy changed the title Focus on flaky test, with increased MaxLength Disable flaky test on Windows Nov 23, 2022
@feloy feloy closed this Nov 23, 2022
@feloy feloy reopened this Nov 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anandrkskd
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 24, 2022
rm3l
rm3l approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 24, 2022
@feloy
Copy link
Contributor Author

feloy commented Nov 24, 2022

/override ci/prow/v4.11-integration-e2e
Pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6147d1b into redhat-developer:main Nov 24, 2022
@rm3l rm3l mentioned this pull request Nov 24, 2022
Merged
3 tasks
@rm3l rm3l added the area/Windows Issues or PRs specific to Windows label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

@anandrkskd anandrkskd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/Windows Issues or PRs specific to Windows lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test on Windows
4 participants
@feloy @anandrkskd @rm3l @openshift-merge-robot