Support Alizer-based automatic port detection with odo init interactive mode #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rm3l
added
kind/feature
rm3l
changed the title
rm3l
force-pushed
the
5863-odo-init-interactive-mode-automatic-port-detection-based-on-alizer-detection
branch
from
9bf3883
to
2063b32
Compare
rm3l
force-pushed
the
5863-odo-init-interactive-mode-automatic-port-detection-based-on-alizer-detection
branch
from
2063b32
to
4f0b8ed
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
reviewed
Dec 1, 2022
feloy
approved these changes
Dec 1, 2022
openshift-ci
bot
added
the
lgtm
|
/hold Waiting for #6378 to be merged. It bumped Alizer to a more recent commit. |
openshift-ci
bot
added
the
do-not-merge/hold
…ted" This is confusing to users.
This is because we specifically need to display the ports at the same moment when the language, project type and Devfile are displayed to the end user (when source code is present)
…prior to asking for its customization The case of multi-container components will be handled in [1]. Otherwise, the container component ports (all but the Debug ports) are replaced with the right application ports. [1] redhat-developer#6264
This allows such ports to be port-forwarded first, before the Debug ones.
rm3l
force-pushed
the
5863-odo-init-interactive-mode-automatic-port-detection-based-on-alizer-detection
branch
from
ff4083c
to
e82b0a0
Compare
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
feloy
approved these changes
Dec 6, 2022
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.11-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
deleted the
5863-odo-init-interactive-mode-automatic-port-detection-based-on-alizer-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
/area init
What does this PR do / why we need it:
This bumps the Alizer library to a more recent commit, in order to benefit from automatic port detection when running
odo initinteractively from a directory with source code.More details and context in #5863
Which issue(s) this PR fixes:
Fixes #5863
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
How port detection works is explained in detail in this document.