odo delete component on podman with --name #6437
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
the
kind/feature
feloy
changed the title
feloy
force-pushed
the
feature-6296/odo-delete-named-component-podman-main
branch
from
ccef060
to
86557b6
Compare
| if len(podmanResources) > 0 { | ||
| log.Printf("The following pods and associated volumes will be deleted from podman:") | ||
| for _, pod := range podmanResources { | ||
| fmt.Printf("\t- %s\n", pod.GetName()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you could modify printDevfileComponents to print podman resources as well so that the output is similar for both devfile and podman resources?
| @@ -285,6 +319,7 @@ func (o *ComponentOptions) deleteDevfileComponent(ctx context.Context) error { | |||
| log.Warningf("Failed to delete the pod %q from podman: %s\n", pod.GetName(), err) | |||
| } | |||
| } | |||
| log.Infof("The component %q is successfully deleted from podman", o.name) | |||
There was a problem hiding this comment.
| log.Infof("The component %q is successfully deleted from podman", o.name) | |
| log.Infof("The component %q is successfully deleted from podman", componentName) |
| componentName, namespace string, | ||
| k8sResources []unstructured.Unstructured, | ||
| podmanResources []*corev1.Pod, | ||
| ) { | ||
| log.Infof("This will delete %q from the namespace %q.", componentName, namespace) |
There was a problem hiding this comment.
Can you fix this message to also indicate podman if podmanResources are present?
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.11-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind feature
What does this PR do / why we need it:
odo delete componenton podman with--nameWhich issue(s) this PR fixes:
Fixes #6296
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: