Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate Doc: Quickstart Guides #6470

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Automate Doc: Quickstart Guides #6470

merged 2 commits into from
Jan 6, 2023

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind tests
/area documentation

What does this PR do / why we need it:
This PR adds tests to verify quickstart doc outputs.

Which issue(s) this PR fixes:

Fixes #6466

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added kind/tests area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Jan 6, 2023
@netlify
Copy link

netlify bot commented Jan 6, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 6f223b7
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b82a838742f40008d4e028

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

NoCluster Tests on commit bde10e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

OpenShift Tests on commit bde10e3 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Unit Tests on commit bde10e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Validate Tests on commit bde10e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Kubernetes Tests on commit bde10e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Windows Tests (OCP) on commit bde10e3 finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Jan 6, 2023

@valaparthvi When running the tests locally, with a Kubernetes cluster, I get the following error. Do you get it too?

Expected
      <string>:   (
        	"""
        	... // 11 identical lines
        	✓  Pod is Running
        	✓  Syncing files into the container [1s]
      + 	cat: /opt/odo/.odo_cmd_run.pid: No such file or directory
        	✓  Building your application in container on cluster (command: build) [1s]
        	•  Executing the application (command: run)  ...
      + 	196
      + 	0
      + 	196
      + 	0
        	-  Forwarding from 127.0.0.1:40001 -> 8080
        	
        	... // 11 identical lines
        	"""
        )
      
  to be empty

@valaparthvi
Copy link
Contributor Author

@valaparthvi When running the tests locally, with a Kubernetes cluster, I get the following error. Do you get it too?

Expected
      <string>:   (
        	"""
        	... // 11 identical lines
        	✓  Pod is Running
        	✓  Syncing files into the container [1s]
      + 	cat: /opt/odo/.odo_cmd_run.pid: No such file or directory
        	✓  Building your application in container on cluster (command: build) [1s]
        	•  Executing the application (command: run)  ...
      + 	196
      + 	0
      + 	196
      + 	0
        	-  Forwarding from 127.0.0.1:40001 -> 8080
        	
        	... // 11 identical lines
        	"""
        )
      
  to be empty

I didn't encounter it while working on the tests, I'll re-run the tests though.

@valaparthvi
Copy link
Contributor Author

@valaparthvi When running the tests locally, with a Kubernetes cluster, I get the following error. Do you get it too?

Expected
      <string>:   (
        	"""
        	... // 11 identical lines
        	✓  Pod is Running
        	✓  Syncing files into the container [1s]
      + 	cat: /opt/odo/.odo_cmd_run.pid: No such file or directory
        	✓  Building your application in container on cluster (command: build) [1s]
        	•  Executing the application (command: run)  ...
      + 	196
      + 	0
      + 	196
      + 	0
        	-  Forwarding from 127.0.0.1:40001 -> 8080
        	
        	... // 11 identical lines
        	"""
        )
      
  to be empty

I didn't encounter it while working on the tests, I'll re-run the tests though.

I can see them now. I'll try to skip those.

@feloy
Copy link
Contributor

feloy commented Jan 6, 2023

@valaparthvi This PR should remove the unwanted output: #6473
Feel free to integrate the change in your PR

@valaparthvi
Automate quickstart guide doc
6e35eae 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi
update with phmartin's change to fix pid related ouput and fix test name
6f223b7 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 6, 2023
@valaparthvi
Copy link
Contributor Author

/override OpenShift-Integration-tests/OpenShift-Integration-tests

I am overriding the test for now because the failure is unrelated to the changes made here, but the following failure needs to be investigated:

Expected
      <string>:   __
       /  \__     Developing using the "xpczcj" Devfile
       \__/  \    Namespace: cmd-logs-test189tbj
       /  \__/    odo version: v3.5.0
       \__/
      
      ↪ Deploying to the cluster in developer mode
       •  Waiting for Kubernetes resources  ...
       •  Creating resource Pod/myapp-inner  ...
      
 ✓  Creating resource Pod/myapp-inner 
       âš   Pod is Pending
       ✓  Pod is Running
       •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...
      
 ✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [1s]
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource
      
       •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...
      
 ✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [1s]
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource

@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

I am overriding the test for now because the failure is unrelated to the changes made here, but the following failure needs to be investigated:

Expected
     <string>:   __
      /  \__     Developing using the "xpczcj" Devfile
      \__/  \    Namespace: cmd-logs-test189tbj
      /  \__/    odo version: v3.5.0
      \__/
     
     ↪ Deploying to the cluster in developer mode
      •  Waiting for Kubernetes resources  ...
      •  Creating resource Pod/myapp-inner  ...
     
✓  Creating resource Pod/myapp-inner 
      âš   Pod is Pending
      ✓  Pod is Running
      •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...
     
✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [1s]
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource
     
      •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...
     
✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [1s]
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi valaparthvi mentioned this pull request Jan 6, 2023
Closed
@valaparthvi
Copy link
Contributor Author

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 62f5131 into redhat-developer:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@kadel kadel Awaiting requested review from kadel

Assignees

@feloy feloy

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate Doc: Quickstart Guide
3 participants
@valaparthvi @feloy @openshift-merge-robot