Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[podman] show logs when command fails #6481

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jan 10, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6434

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 10, 2023
@feloy feloy requested a review from rm3l January 10, 2023 08:56
@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 914e5d6
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63c511a1d968a70008e9bb59

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

OpenShift Tests on commit 4b1484c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

NoCluster Tests on commit 4b1484c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Unit Tests on commit 4b1484c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Validate Tests on commit 4b1484c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Windows Tests (OCP) on commit 4b1484c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Kubernetes Tests on commit 4b1484c finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6434/logs-podman branch 3 times, most recently from 22e0fde to 22522ea Compare January 10, 2023 15:28
@feloy feloy closed this Jan 11, 2023
@feloy feloy reopened this Jan 11, 2023
@feloy feloy removed the request for review from anandrkskd January 11, 2023 08:38
pkg/podman/logs.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy requested a review from rm3l January 16, 2023 10:20
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 16, 2023
@feloy
Copy link
Contributor Author

feloy commented Jan 16, 2023

/override windows-integration-test/Windows-test
Flaky e2e test

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test
Flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 682e517 into redhat-developer:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Logs for podman platform
3 participants