Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate Podman tests in namespaces #6499

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Isolate Podman tests in namespaces #6499

merged 10 commits into from
Jan 23, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jan 17, 2023 •
edited
Loading

What type of PR is this:
/kind tests
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Unblocks #6485 by isolating each Podman test under a dedicated namespace. See #6485 (comment)

Note that even with isolated namespaces, two Podman containers cannot have the same name (I guess they share the same underlying storage.conf). So #6504 made sure to use random component names in our tests.

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
With proper isolation, we can run those Podman tests in parallel. This is the tentative done in 66ed98f (#6499), which works well on GitHub Actions (up to a certain number of parallel nodes), but used to fail locally.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 66ed98f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63ce63bf6474e100085df7ae

@rm3l rm3l changed the title isolate podman tests in namespaces [WIP] Isolate Podman tests in namespaces Jan 17, 2023
@rm3l rm3l changed the title [WIP] Isolate Podman tests in namespaces [WIP] Isolate Podman tests in namespaces and run them in parallel Jan 17, 2023
@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

OpenShift Tests on commit 095b122 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

NoCluster Tests on commit 095b122 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Unit Tests on commit 095b122 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Validate Tests on commit 095b122 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Kubernetes Tests on commit 095b122 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 17, 2023 •
edited
Loading

Windows Tests (OCP) on commit 095b122 finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the isolate_podman_tests_in_namespaces branch from 8174628 to e7987fa Compare January 17, 2023 21:17
@rm3l rm3l mentioned this pull request Jan 18, 2023
Merged
3 tasks
@rm3l
Copy link
Member Author

rm3l commented Jan 18, 2023

Podman tests are not passing due to conflicting Devfile component names: https://github.com/redhat-developer/odo/actions/runs/3943370985/jobs/6748117484#step:5:359

/hold

Blocked on #6504, which should fix this behavior.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 18, 2023
@rm3l rm3l mentioned this pull request Jan 18, 2023
Merged
3 tasks
@rm3l rm3l force-pushed the isolate_podman_tests_in_namespaces branch from e7987fa to 037f153 Compare January 18, 2023 17:58
@rm3l rm3l changed the title [WIP] Isolate Podman tests in namespaces and run them in parallel Isolate Podman tests in namespaces and run them in parallel Jan 18, 2023
@rm3l rm3l marked this pull request as ready for review January 18, 2023 19:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 18, 2023
@rm3l rm3l added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/tests area/odo-on-podman Issues or PRs related to running odo against Podman and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. labels Jan 18, 2023
@rm3l rm3l closed this Jan 18, 2023
@rm3l rm3l reopened this Jan 18, 2023
@rm3l rm3l mentioned this pull request Jan 19, 2023
Merged
3 tasks
@rm3l rm3l force-pushed the isolate_podman_tests_in_namespaces branch 4 times, most recently from 48b6e2a to 1cdb02b Compare January 20, 2023 16:31
@rm3l rm3l requested a review from feloy January 23, 2023 08:59
@rm3l rm3l closed this Jan 23, 2023
@rm3l rm3l reopened this Jan 23, 2023
@rm3l rm3l force-pushed the isolate_podman_tests_in_namespaces branch 9 times, most recently from ea15db2 to edf1d58 Compare January 23, 2023 10:29
@rm3l
Copy link
Member Author

rm3l commented Jan 23, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 23, 2023
@rm3l
Allow overridding the number of parallel nodes for Podman integration…
66ed98f 
… tests

This way, we could be able to run them in parallel on GitHub
but sequentially (default) locally.
This will still benefit us by reducing the time it takes to run such tests on GitHub.

Meanwhile, we can look into the issues we have locally with parallelization.

Note that it is still possible to run them locally in parallel via
the PODMAN_EXEC_NODE env var.
@rm3l rm3l force-pushed the isolate_podman_tests_in_namespaces branch from edf1d58 to 66ed98f Compare January 23, 2023 10:38
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 23, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 23, 2023
@feloy
Copy link
Contributor

feloy commented Jan 23, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
Previous run passed

@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
Previous run passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jan 23, 2023

/override ci/prow/v4.11-integration-e2e
Flaky e2e test

@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 511792a into redhat-developer:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
area/odo-on-podman Issues or PRs related to running odo against Podman area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.6.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@rm3l @feloy @openshift-merge-robot