Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: odo dev unable to sync files with name containing special characters #6507

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Fix: odo dev unable to sync files with name containing special characters #6507

merged 3 commits into from
Jan 20, 2023

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jan 18, 2023 •
edited
Loading

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind bug

What does this PR do / why we need it:
This PR allows to sync files with special characters.
Which issue(s) this PR fixes:

Fixes #6503

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. Clone https://github.com/devfile/devfile-web
  2. odo init --devfile nodejs-react --name devfile-web
  3. odo dev

@valaparthvi
Fix: odo dev unable to sync files with name containing special charac…
068b5ab 
…ters

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@netlify
Copy link

netlify bot commented Jan 18, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit b60f6cd
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63ca4de3dc72e60009661fbf

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. labels Jan 18, 2023
@openshift-ci openshift-ci bot requested review from feloy and rm3l January 18, 2023 11:32
@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

OpenShift Tests on commit b1dd710 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

NoCluster Tests on commit b1dd710 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Unit Tests on commit b1dd710 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Validate Tests on commit b1dd710 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Kubernetes Tests on commit b1dd710 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Windows Tests (OCP) on commit b1dd710 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi changed the title [WIP] Fix: odo dev unable to sync files with name containing special characters Fix: odo dev unable to sync files with name containing special characters Jan 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 19, 2023
@valaparthvi valaparthvi changed the title Fix: odo dev unable to sync files with name containing special characters [WIP] Fix: odo dev unable to sync files with name containing special characters Jan 19, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 19, 2023
@valaparthvi
Cover in unit tests and refactor them
ebfeab4 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi force-pushed the 6503-fix-sync-with-special-characters branch from 762c5b9 to ebfeab4 Compare January 20, 2023 07:58
@valaparthvi
Add test for globEscape
b60f6cd 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi changed the title [WIP] Fix: odo dev unable to sync files with name containing special characters Fix: odo dev unable to sync files with name containing special characters Jan 20, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 20, 2023
@valaparthvi
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 20, 2023
@rm3l rm3l closed this Jan 20, 2023
@rm3l rm3l reopened this Jan 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@openshift-merge-robot openshift-merge-robot merged commit aa8a3c7 into redhat-developer:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo dev unable to sync files with name containing special characters
3 participants
@valaparthvi @rm3l @openshift-merge-robot