Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server binaries for "osx-x86_64" are not found #729

Closed
shwao opened this issue Jun 30, 2022 · 3 comments · Fixed by #732 or #733
Closed

Server binaries for "osx-x86_64" are not found #729

shwao opened this issue Jun 30, 2022 · 3 comments · Fixed by #732 or #733
Labels
bug Something isn't working build
Milestone
0.22.0

Comments

@shwao
Copy link

shwao commented Jun 30, 2022

The URL for the osx-x86_64 binaries configured here:

vscode-xml/package.json

Line 23 in a026ba1

"osx-x86_64": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-osx-x86_64.zip",

is returning 404 Not Found.

The other ones work.
@fbricon
Copy link
Collaborator

fbricon commented Jun 30, 2022

yes, it should be https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-darwin.zip

@fbricon fbricon added the bug Something isn't working label Jun 30, 2022
@rgrunber
Copy link
Member

rgrunber commented Jun 30, 2022 •
edited
Loading

I think it's a bug in the naming for the development version at https://github.com/redhat-developer/vscode-xml/blob/master/.github/workflows/native-image.yaml#L115 . We alternate in a few places between osx-x86_64 and darwin so we just need to modify the build to match. It's correct on windows and linux.

Also, once once #725 is merged, even development builds will only download the binary LemMinX if they've explicitly chosen to use a generic vsix.

@rgrunber rgrunber mentioned this issue Jul 4, 2022
Merged
@datho7561 datho7561 added the build label Jul 4, 2022
@datho7561 datho7561 added this to the 0.22.0 milestone Jul 4, 2022
@rgrunber rgrunber mentioned this issue Jul 4, 2022
Merged
@rgrunber
Copy link
Member

rgrunber commented Jul 4, 2022

I've also fixed the release location for the development build https://github.com/redhat-developer/vscode-xml/releases/tag/latest .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build
Projects
None yet
Milestone
0.22.0
4 participants
@fbricon @rgrunber @datho7561 @shwao