Xinclude schema validation issues

[oscarlevin]

I'm very thankful that vscode-xml now helps validate PreTeXt documents against it's RelaxNG schema. I have enabled the xinclude validation, and it does appear that the files included this way get checked as well. However, there are two issues.

1. In the root tag of the root document, I get validation errors of the form:

There are '2' errors in 'ch_intro.ptx'.xml
ch_intro.ptx(6, 2): Document root element "chapter", must match DOCTYPE root "null".
ch_intro.ptx(6, 2): element "chapter" not allowed here; expected element "pretext"

The schema has start element <pretext> and the <chapter> element is in the right place, but it is the root element of ch_intro.ptx file.

2. When I open up a file that was the target of an <xi:include />, the root element of that "fragment" is not <pretext> (it is usually <chapter> or <section> ) so that gives a validation error (that the element is not allowed there.

I understand that the 2nd issue might be impossible to really fix (apparently oXygen doesn't fix it), but perhaps the error can be made less severe in settings for the top element of any document. The first issue seems like a bug of the xinclude mechanism.

[angelozerr]

1. In the root tag of the root document, I get validation errors of the form:

I think it is a bug with file association, because if you remove the file association and you use xml-model processing instruction it is working (you don't have those errors), BUT you have new errors because of 2 I think.

2. When I open up a file that was the target of an <xi:include />, the root element of that "fragment" is not (it is usually or
   ) so that gives a validation error (that the element is not allowed there.

I don't know how to fix that for the moment, but you have the same error when you open the ptx root file (see my screenshot). XINclude is for the moment experimental, we need to find some time to improve it.

I will fix the file association problem at first.

[angelozerr]

1. In the root tag of the root document, I get validation errors of the form:

I will provide soon a fix for that.

2. When I open up a file that was the target of an <xi:include />, the root element of that "fragment" is not (it is usually or
   ) so that gives a validation error (that the element is not allowed there.

In docbook there is the same idea, you can declare a book element which have some chapter elements. The DTD docbook allowed to write an XML with book as root element and chapter as root element. I think your pretext.rng should allows that too.

[angelozerr]

1. In the root tag of the root document, I get validation errors of the form:

See eclipse-lemminx/lemminx#1421

[angelozerr]

@oscarlevin the PR eclipse-lemminx/lemminx#1421 has been merged. Tomorrow you could install the prerelease and it should fix your issue with DOCTYPE.

[oscarlevin]

Thanks @angelozerr . I'll check that out. Assuming that works, I think we can close this. I've figured out how to add new elements to <start> in Relax NG and that takes care of issue 2. Actually, it seems to also fix issue 1.

[angelozerr]

@oscarlevin could you try the prerelease and check if the issue 1 is fixed?

[angelozerr]

Fixed with eclipse-lemminx/lemminx#1421

@oscarlevin if you find some issues with xinclude, please reopen it.