Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Auto indent" setting is broken in version 0.25.0 #899

Closed
pvburkov opened this issue May 3, 2023 · 6 comments · Fixed by #900
Closed

"Auto indent" setting is broken in version 0.25.0 #899

pvburkov opened this issue May 3, 2023 · 6 comments · Fixed by #900
Labels
bug Something isn't working
Milestone
0.26.0

Comments

@pvburkov
Copy link

pvburkov commented May 3, 2023 •
edited
Loading

Hello!

Unfortunately, after my update to version 0.25.0, "auto indent" setting was broken for XML and XSD files (even with value "full" there is no indentation after pressing Enter). In version 0.24.0 this rule is working fine.

Here're some of my tech parameters (if you need more, please, tag me in comments below):

  • OS: Windows 10 Home Edition 22H2 (19045.2846)
  • VS Code: 1.77.3
@angelozerr
Copy link
Contributor

I suspect the problem comes from a179451

@JessicaJHee @datho7561 canyou reproduce it?

@datho7561
Copy link
Contributor

Yes, I can reproduce the issue, and it comes from the commit you mentioned. Sorry about that, I must have missed it in review.

datho7561 added a commit to datho7561/vscode-xml that referenced this issue May 3, 2023
@datho7561
Fix indentation in XML/XSD files
4664d8d 
Make sure to upcast `string|DocumentFilter` correctly when setting
indentation rules.

Fixes redhat-developer#899
@datho7561 datho7561 mentioned this issue May 3, 2023
Merged
@datho7561 datho7561 added the bug Something isn't working label May 3, 2023
@angelozerr
Copy link
Contributor

es, I can reproduce the issue, and it comes from the commit you mentioned. Sorry about that, I must have missed it in review.

No problem @datho7561 it is too my fault:) Thanks for your fix #900, I think you are in the right direction.

datho7561 added a commit to datho7561/vscode-xml that referenced this issue May 3, 2023
@datho7561
Fix indentation in XML/XSD files
4b1f693 
Make sure to upcast `string|DocumentFilter` correctly when setting
indentation rules.

Fixes redhat-developer#899
datho7561 added a commit that referenced this issue May 3, 2023
@datho7561
Fix indentation in XML/XSD files
bf0aa48 
Make sure to upcast `string|DocumentFilter` correctly when setting
indentation rules.

Fixes #899
@datho7561 datho7561 added this to the 0.25.1 milestone May 3, 2023
@angelozerr
Copy link
Contributor

@pvburkov please note that @datho7561 did a fix now for your issue and you will able to install prerelease tomorrow I think to test it

@pvburkov
Copy link
Author

pvburkov commented May 4, 2023

@angelozerr and redhead-developer team, thank you very much! Auto-indentation works again)

@angelozerr
Copy link
Contributor

angelozerr commented May 4, 2023 •
edited
Loading

@pvburkov glad it fixes your issue. The congrat is for @datho7561 and @JessicaJHee , I did nothing for this fix:)

@rgrunber rgrunber moved this to ✅ Done in IDE Cloudaptors May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
IDE Cloudaptors
Archived in project
Milestone
0.26.0
Development

Successfully merging a pull request may close this issue.

Fix indentation in XML/XSD files datho7561/vscode-xml
3 participants
@angelozerr @pvburkov @datho7561