Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for json-schema > draft-7 #856

Open
mitodrummer opened this issue Mar 6, 2023 · 9 comments
Open

Support for json-schema > draft-7 #856

mitodrummer opened this issue Mar 6, 2023 · 9 comments

Comments

@mitodrummer
Copy link

Summary

Hello, I am wondering if there is a plan to update to the newest json schema (2020-12 at the time of this ticket). I am needing features from 2019 schema.

TY

@mitodrummer
Copy link
Author

microsoft/vscode-json-languageservice#133

Looks like maybe version 4.2.1 of json-languageservice should have it :)

@remcohaszing
Copy link
Contributor

FYI #637 explains why the version is locked. That issue includes a number of related references.

As the reporter of that issue I would totally understand if the version is unlocked in order to support newer JSON schema features.

@gorkem
Copy link
Collaborator

gorkem commented Mar 26, 2023

@remcohaszing I think we will have to move to a later vscode-json-languageservice not only to get schema support for more recent schema versions but also for issues like #823 are also fixed by later versions.

@remcohaszing
Copy link
Contributor

I suggest to wait for SchemaStore/schemastore#2858.

@gorkem
Copy link
Collaborator

gorkem commented Mar 27, 2023

No problem. Unfortunately, there are breaking changes on vscode-language-service that we need to adjust yaml-language-server for.

@amimas
Copy link

amimas commented Aug 13, 2023

Any update available for this?

@apupier
Copy link
Member

apupier commented Aug 28, 2023

microsoft/vscode-json-languageservice#133

Looks like maybe version 4.2.1 of json-languageservice should have it :)

Unfortunately, it seems that it is not workign as expected, this issue is linked from the pointed issue microsoft/vscode#98724

@remcohaszing
Copy link
Contributor

I don’t know what’s the hold up for SchemaStore/schemastore#2858, but it’s taking a long time. It only affects 3 schemas, of which I manage 1, so I can create a workaround for that.

I think it’s best to just update. This will break for a couple of users, but benefit the majority.

@michaeltlombardi
Copy link

michaeltlombardi commented Sep 13, 2023

Updating would be very helpful, as there's a good number of useful keywords in 2019-09 that work even without full support for dynamic references/anchors/vocabulary - notably, the unevaluated* and dependent* keywords for schema composition/extension/conditional validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants