Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial feedback code #29

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

RobotSail
Copy link
Collaborator

This PR introduces a simple way of gathering feedback, using an SQLite database and the streamlit-feedback component.

Feedback data is stored in a single table with the schema:

CREATE TABLE IF NOT EXISTS feedback (
  id integer PRIMARY KEY AUTOINCREMENT,
  type text NOT NULL,
  score text NOT NULL,
  text text,
  timestamp text NOT NULL
);

Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RobotSail
Copy link
Collaborator Author

The build checks are failing only because secrets aren't provided to pull requests. Specifically the image build is trying to login but GitHub won't provide it with the credentials.

@RobotSail RobotSail requested a review from hemajv January 17, 2024 15:28
@oindrillac
Copy link
Contributor

The database is created in our openshift space and the UI works as expected https://ui-api-doc-gen.apps.platform-sts.pcbk.p1.openshiftapps.com/

We can make some UI enhancements like the position of the feedback component and the exact choice of buttons.

But this is an awesome start @RobotSail Thanks for putting this together quickly LGTM

Copy link
Collaborator

@hemajv hemajv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobotSail this looks great! Thanks for the quick additions 👍

@oindrillac oindrillac merged commit b93c425 into redhat-et:main Jan 17, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants