feat: implement proper hpexpire command signatures and tests (#2006)

* feat: implement proper hpexpire command signatures and tests

* feat: implement proper hpexpire command signatures and tests

* chore: update @ioredis/commands to 1.3.1

---------

Co-authored-by: Pavel Pashov <pavel.pashov@redis.com>

Author: vpoliatychko

bin/returnTypes.js

@@ -143,6 +143,7 @@ module.exports = {
   hello: "unknown[]",
   hexists: "number",
   hexpire: "number[]",
+  hpexpire: "number[]",
   hget: "string | null",
   hgetall: "[field: string, value: string][]",
   hincrby: "number",

lib/utils/RedisCommander.ts

@@ -4028,6 +4028,23 @@ interface RedisCommander<Context extends ClientContext = { type: "default" }> {
     ...args: [key: RedisKey, ...fieldValues: (string | Buffer | number)[]]
   ): Result<"OK", Context>;
 
+  /**
+   * Set expiry for hash field using relative time to expire (milliseconds)
+   * - _group_: hash
+   * - _complexity_: O(N) where N is the number of specified fields
+   * - _since_: 7.4.0
+   */
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[], callback: Callback<number[]>]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[]]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, nx: 'NX', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[], callback: Callback<number[]>]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, nx: 'NX', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[]]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, xx: 'XX', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[], callback: Callback<number[]>]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, xx: 'XX', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[]]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, gt: 'GT', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[], callback: Callback<number[]>]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, gt: 'GT', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[]]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, lt: 'LT', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[], callback: Callback<number[]>]): Result<number[], Context>;
+  hpexpire(...args: [key: RedisKey, milliseconds: number | string, lt: 'LT', fieldsToken: 'FIELDS', numfields: number | string, ...fields: (string | Buffer)[]]): Result<number[], Context>;
+
   /**
    * Get one or multiple random fields from a hash
    * - _group_: hash

package-lock.json

@@ -43,7 +43,7 @@
     "url": "https://opencollective.com/ioredis"
   },
   "dependencies": {
-    "@ioredis/commands": "^1.3.0",
+    "@ioredis/commands": "^1.3.1",
     "cluster-key-slot": "^1.1.0",
     "debug": "^4.3.4",
     "denque": "^2.1.0",

package.json

@@ -0,0 +1,72 @@
+import Redis from "../../lib/Redis";
+import { expect } from "chai";
+
+describe("hpexpire", () => {
+  const hashKey = "test_hash_key";
+  const field = "test_field";
+
+  it("should handle non-existing field", async () => {
+    const redis = new Redis();
+
+    const result = await redis.hpexpire(
+      "non_existing_hash_key",
+      60,
+      "NX",
+      "FIELDS",
+      1,
+      "non_existing_field"
+    );
+
+    expect(result).to.deep.equal([-2]);
+  });
+
+  it("should handle existing field", async () => {
+    const redis = new Redis();
+
+    await redis.hset(hashKey, field, "value");
+
+    const result = await redis.hpexpire(hashKey, 60, "FIELDS", 1, field);
+
+    expect(result).to.deep.equal([1]);
+  });
+
+  it("should return 0 when condition is not met", async () => {
+    const redis = new Redis();
+
+    await redis.hset(hashKey, field, "value");
+    await redis.hpexpire(hashKey, 60, "FIELDS", 1, field); // Set initial expiry
+
+    // Try to set expiry with NX when field already has expiry
+    const result = await redis.hpexpire(hashKey, 120, "NX", "FIELDS", 1, field);
+
+    expect(result).to.deep.equal([0]);
+  });
+
+  it("should return 2 when expiring field with 0 seconds", async () => {
+    const redis = new Redis();
+
+    await redis.hset(hashKey, field, "value");
+
+    const result = await redis.hpexpire(hashKey, 0, "FIELDS", 1, field);
+
+    expect(result).to.deep.equal([2]);
+  });
+
+  it("should expire multiple fields", async () => {
+    const redis = new Redis();
+
+    await redis.hset(hashKey, field, "value", "field2", "value2");
+
+    const result = await redis.hpexpire(
+      hashKey,
+      60,
+      "FIELDS",
+      3,
+      field,
+      "field2",
+      "non_existing_field"
+    );
+
+    expect(result).to.deep.equal([1, 1, -2]);
+  });
+});