From cf3b62ac8ba70a333b781f7b47c348eb65f03f0c Mon Sep 17 00:00:00 2001 From: 50-Course Date: Tue, 13 Feb 2024 13:30:40 +0100 Subject: [PATCH 1/2] Remove dead code in `src/main/java/redis/clients/jedis/JedisPubSubBase` module. There is a commented code that invalidates a client connection when the Connection is no longer listening. This patch aims to remove it --- src/main/java/redis/clients/jedis/BinaryJedisPubSub.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/redis/clients/jedis/BinaryJedisPubSub.java b/src/main/java/redis/clients/jedis/BinaryJedisPubSub.java index 96123256c6..cf1c0ae8a5 100644 --- a/src/main/java/redis/clients/jedis/BinaryJedisPubSub.java +++ b/src/main/java/redis/clients/jedis/BinaryJedisPubSub.java @@ -6,4 +6,5 @@ public abstract class BinaryJedisPubSub extends JedisPubSubBase { protected final byte[] encode(byte[] raw) { return raw; } + } From 50b7568559179fd1217941bb27b1ae330292924b Mon Sep 17 00:00:00 2001 From: 50-Course Date: Thu, 15 Feb 2024 03:19:07 +0100 Subject: [PATCH 2/2] remove unreferenced connection client --- src/main/java/redis/clients/jedis/JedisPubSubBase.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/main/java/redis/clients/jedis/JedisPubSubBase.java b/src/main/java/redis/clients/jedis/JedisPubSubBase.java index 7092680e33..091a21e257 100644 --- a/src/main/java/redis/clients/jedis/JedisPubSubBase.java +++ b/src/main/java/redis/clients/jedis/JedisPubSubBase.java @@ -174,7 +174,5 @@ private void process() { } } while (isSubscribed()); -// /* Invalidate instance since this thread is no longer listening */ -// this.client = null; } }