Add builders for classes based on UnifiedJedis

[uglide]

Motivation

This change creates a foundation for providing a new client class(es) for AA failover, allowing developers to easily instantiate JedisPooled, JedisSentineled, JedisCluster, etc.

Review

Summary

This commit introduces a formal Builder pattern for UnifiedJedis-based clients (JedisPooled, JedisCluster, JedisSentineled) and adds a shared builder base (AbstractClientBuilder) plus specialized builders for standalone, cluster, and sentinel deployments. It also exposes a couple of configuration hooks, aligns RediSearch default dialect handling, and adds reflection-based tests to ensure builder coverage over the existing constructor surfaces. Build tooling is adjusted to preserve parameter names for those tests.

---

High-level Impact

• Additive public API: new static builder() entry points and builder classes under redis.clients.jedis.builders.
• Internal visibility tweak: UnifiedJedis constructor made package-visible to allow subclass super(...) calls.
• Slightly broader access: CommandObjects.setKeyArgumentPreProcessor() is now public.
• Tests and tooling: reflection-based tests to validate builder coverage; Maven profile to compile with parameter names.
• Behavioral defaults remain intact (e.g., RediSearch DEFAULT_DIALECT still 2, now referenced via constant).

---

Detailed Changes

1) Builders

• New classes:
  • redis.clients.jedis.builders.AbstractClientBuilder<T,C>
  • redis.clients.jedis.builders.StandaloneClientBuilder
  • redis.clients.jedis.builders.ClusterClientBuilder
  • redis.clients.jedis.builders.SentinelClientBuilder

Key capabilities (AbstractClientBuilder):

• Common options: poolConfig, cache/cacheConfig, connectionProvider, commandExecutor, commandObjects, redisProtocol, key preprocessor, JSON mapper, search dialect.
• Build flow: validate -> optional cache from cacheConfig -> default provider/executor if unset -> apply common config to CommandObjects -> instantiate concrete client.
• Cache implies RESP3: calling cache(...) or cacheConfig(...) forces redisProtocol=RESP3 (UnifiedJedis guards against cache+RESP2).
• applyCommonConfiguration wires:
  • CommandObjects.setKeyArgumentPreProcessor(...)
  • CommandObjects.setJsonObjectMapper(...)
  • CommandObjects.setDefaultSearchDialect(...) when non-default

Specialized builders:

• StandaloneClientBuilder
  • hostAndPort(String,int|HostAndPort), clientConfig(JedisClientConfig)
  • fromURI(String|URI) builds DefaultJedisClientConfig based on URI and sets host/port
  • Default provider: PooledConnectionProvider(hostAndPort, config, cache, poolConfig)
  • Validation intends to ensure either URI or host/port, not both
• ClusterClientBuilder
  • nodes(Set), clientConfig, maxAttempts(int), maxTotalRetriesDuration(Duration), topologyRefreshPeriod(Duration)
  • Default provider: ClusterConnectionProvider(nodes, config, cache, poolConfig, topologyRefreshPeriod)
  • Validates nodes non-empty and non-negative durations/attempts
• SentinelClientBuilder
  • masterName(String), sentinels(Set), clientConfig, sentinelClientConfig
  • Default provider: SentineledConnectionProvider(masterName, clientConfig, cache, poolConfig, sentinels, sentinelClientConfig)
  • Validates required fields

2) Jedis* classes integrate builders

• JedisPooled, JedisCluster, JedisSentineled:
  • Add private constructors accepting (CommandExecutor, ConnectionProvider, CommandObjects, RedisProtocol, Cache) and delegating to super(...)
  • Add public static inner Builder extends respective specialized builder
  • Add public static Builder builder() factory method

3) UnifiedJedis visibility

• UnifiedJedis(CommandExecutor, ConnectionProvider, CommandObjects, RedisProtocol, Cache) constructor changed from private to package-visible to enable subclass super(...) calls from Jedis*.

4) CommandObjects tuning

• Replace hard-coded default search dialect (2) with SearchProtocol.DEFAULT_DIALECT.
• setKeyArgumentPreProcessor made public (was @experimental with package access). This enables configuration via builders.

5) RediSearch protocol constant usage

• SearchDefaultDialectTest and CommandObjects now reference SearchProtocol.DEFAULT_DIALECT rather than literals. SearchProtocol.DEFAULT_DIALECT remains 2.

6) Build tooling to support reflection tests

• Makefile: mvn-test-local and mvn-test now pass -Dwith-param-names=true.
• pom.xml: new profile tests-with-params activated via -Dwith-param-names=true, enabling:
  • maven-compiler-plugin true (preserve method/parameter names)
  • maven-surefire-plugin argLine includes --add-opens java.base/java.lang=ALL-UNNAMED ${JVM_OPTS}

7) Tests

• New reflection-based coverage tests:
  • builders/JedisPooledConstructorReflectionTest
  • builders/JedisClusterConstructorReflectionTest
  • builders/JedisSentineledConstructorReflectionTest
  • builders/UnifiedJedisConstructorReflectionTest
• Purpose: verify that for every constructor of the target classes, the builder surface offers an equivalent configuration path (maps each parameter type/name to a builder option). Tests assert full coverage and log any gaps.

---

API/Compatibility Assessment

• Additive: New builder APIs are additive; existing constructors remain.
• Internal constructor visibility change is not exposed as public API but is a package-level relaxation; safe and contained.
• Making setKeyArgumentPreProcessor public increases surface area; consider de-@experimental or documenting stability expectations.
• No default behavioral changes beyond wiring options when using the builder.

[ggivo]

Approach with the builders looks good.
I have put some comments, and have concerns around tests validating the constructor coverage.

[atakavci]

missing important part is that this instance of commandObjects is not managed in other abstract or concrete builders.
In addition to that commandobjects is a kind of factory itself and should be left to be instantiated/configured by typed builders(like the other fields in builder) instead of being set as default by abstract one.

[uglide]

Good point! Fixed.