Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating streams data type page with bike story for CLI commands and … #2516

Merged
merged 11 commits into from
Sep 18, 2023

Conversation

sav-norem
Copy link
Contributor

…hugo short codes for tabbed examples

@netlify
Copy link

netlify bot commented Aug 14, 2023

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cd2e477

@sav-norem
Copy link
Contributor Author

@dwdougherty I don't know how to fix this last spellcheck fail since it's like a repeated word so. I tried to get this wordlist right but if you could check this out, that'd be great!

@sav-norem
Copy link
Contributor Author

@dwdougherty okay streams are finally ready

@dwdougherty
Copy link
Collaborator

Okay. I'll have a look soon.

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Savannah. Just a few changes.

The build was fine.

Co-authored-by: David Dougherty <david.dougherty@redis.com>
@dwdougherty
Copy link
Collaborator

These changes are go for merge. Will have to wait until @dmaier-redislabs is back from PTO, as I still don't have permissions.

@sav-norem
Copy link
Contributor Author

@dwdougherty just wanted to bring this back up since it may have gotten forgotten

@dwdougherty
Copy link
Collaborator

Thank you for the reminder, @sav-norem. I'll ask @dmaier-redislabs to merge.

@dmaier-redislabs dmaier-redislabs merged commit 676f49d into redis:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants