Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new REDISMODULE_OPEN_KEY_ACCESS_EXPIRED #2719

Closed

Conversation

moticless
Copy link
Contributor

This PR documents a new flag, REDISMODULE_OPEN_KEY_ACCESS_EXPIRED, to the RM_OpenKey API in Redis modules. This flag allows module developers to access expired keys that have not yet been lazily deleted by the server, providing more control over key lifecycle management within modules.

Copy link

netlify bot commented Sep 23, 2024

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bb3c441

@dwdougherty
Copy link
Collaborator

dwdougherty commented Sep 23, 2024

Hi @moticless . Is this change for the current GA release (7.4) or a future release? If it's a future release, we have automation in place that will automatically update the modules API reference.

Also, this repo is effectively dead. All PRs/Issues should go to the redis/docs repo. I will not be proactively looking here for any change requests.

@@ -2226,6 +2226,7 @@ Extra flags that can be pass to the API under the mode argument:
* `REDISMODULE_OPEN_KEY_NOSTATS` - Don't update keyspace hits/misses counters.
* `REDISMODULE_OPEN_KEY_NOEXPIRE` - Avoid deleting lazy expired keys.
* `REDISMODULE_OPEN_KEY_NOEFFECTS` - Avoid any effects from fetching the key.
* `REDISMODULE_OPEN_KEY_ACCESS_EXPIRED` - Access expired keys that have not yet been deleted.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access expired keys and keys with expired fields? Do we make this distinction?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. maybe i can write instead Access expired (sub)keys that have not yet been deleted.

Anyway i made the change on the wrong repo.

@moticless
Copy link
Contributor Author

moticless commented Sep 24, 2024

@dwdougherty , so this PR is redundant. thanks.

@moticless
Copy link
Contributor Author

We have automation in place that will automatically update the modules API reference.

@moticless moticless closed this Sep 24, 2024
@moticless moticless deleted the new-open-key-access-expired branch September 24, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants