Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising NotImplementedError for certain CLUSTER commands #2504

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 12, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1968
closes #1969

@dvora-h dvora-h added the feature New feature label Dec 12, 2022
@dvora-h dvora-h requested a review from chayim December 12, 2022 14:52
@dvora-h
Copy link
Collaborator Author

dvora-h commented Dec 13, 2022

@shacharPash @vladvildanov

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite understand why these commands need to be written just for them to send an error that says that on purpose they are not implemented, wouldn't that just confuse the user?

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Base: 92.21% // Head: 92.20% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1db497e) compared to base (3fb65de).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2504      +/-   ##
==========================================
- Coverage   92.21%   92.20%   -0.01%     
==========================================
  Files         113      113              
  Lines       29347    29357      +10     
==========================================
+ Hits        27061    27070       +9     
- Misses       2286     2287       +1     
Impacted Files Coverage Δ
redis/commands/cluster.py 94.02% <100.00%> (+0.13%) ⬆️
tests/test_cluster.py 96.79% <100.00%> (-0.11%) ⬇️
tests/test_asyncio/test_pubsub.py 99.37% <0.00%> (-0.16%) ⬇️
tests/test_search.py 99.15% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h merged commit 022a3e8 into redis:master Dec 14, 2022
@dvora-h dvora-h deleted the cluster-commands branch June 18, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for missing command CLUSTER FLUSHSLOTS Add support for missing command CLUSTER BUMPEPOCH
5 participants